From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] block: lift bio_is_zone_append to bio.h
Date: Fri, 1 Nov 2024 06:48:46 +0100 [thread overview]
Message-ID: <20241101054846.GB13514@lst.de> (raw)
In-Reply-To: <f376f179-0173-49b4-b4c6-0cabb8720dfd@kernel.org>
On Fri, Nov 01, 2024 at 02:37:29PM +0900, Damien Le Moal wrote:
> > +static inline bool bio_is_zone_append(struct bio *bio)
> > +{
> > + if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED))
> > + return false;
>
> Nit: this "if" is probably not needed. But it does not hurt either. Since we
> should never be seeing this function being called for the
> !IS_ENABLED(CONFIG_BLK_DEV_ZONED) case, should we add a WARN_ON_ONCE() ?
The point of the IS_ENALBED is to optimize away the code when it can't
be used. The WARN_ON_ONCE would generate worse code than just leaving
the check in.
next prev parent reply other threads:[~2024-11-01 5:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 5:21 fix a few zoned append issues Christoph Hellwig
2024-11-01 5:21 ` [PATCH 1/4] block: fix bio_split_rw_at to take zone_write_granularity into account Christoph Hellwig
2024-11-01 5:34 ` Damien Le Moal
2024-11-01 5:47 ` Christoph Hellwig
2024-11-01 5:21 ` [PATCH 2/4] block: lift bio_is_zone_append to bio.h Christoph Hellwig
2024-11-01 5:37 ` Damien Le Moal
2024-11-01 5:48 ` Christoph Hellwig [this message]
2024-11-04 10:44 ` Johannes Thumshirn
2024-11-01 5:21 ` [PATCH 3/4] btrfs: use bio_is_zone_append in the completion handler Christoph Hellwig
2024-11-01 5:38 ` Damien Le Moal
2024-11-04 10:45 ` Johannes Thumshirn
2024-11-05 6:09 ` Naohiro Aota
2024-11-01 5:21 ` [PATCH 4/4] btrfs: split bios to the fs sector size boundary Christoph Hellwig
2024-11-01 5:40 ` Damien Le Moal
2024-11-04 10:45 ` Johannes Thumshirn
2024-11-05 6:00 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101054846.GB13514@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.