From: kernel test robot <lkp@intel.com>
To: Nava kishore Manne <nava.kishore.manne@amd.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC v2 1/1] fpga-region: Add generic IOCTL interface for runtime FPGA programming
Date: Fri, 1 Nov 2024 08:24:10 +0800 [thread overview]
Message-ID: <202411010840.d7asQAT3-lkp@intel.com> (raw)
In-Reply-To: <20241029091734.3288005-2-nava.kishore.manne@amd.com>
Hi Nava,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.12-rc5 next-20241031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nava-kishore-Manne/fpga-region-Add-generic-IOCTL-interface-for-runtime-FPGA-programming/20241029-181743
base: linus/master
patch link: https://lore.kernel.org/r/20241029091734.3288005-2-nava.kishore.manne%40amd.com
patch subject: [RFC v2 1/1] fpga-region: Add generic IOCTL interface for runtime FPGA programming
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241101/202411010840.d7asQAT3-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241101/202411010840.d7asQAT3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411010840.d7asQAT3-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/fpga/fpga-region.c: In function 'fpga_region_device_open':
>> drivers/fpga/fpga-region.c:186:42: error: invalid use of undefined type 'struct file'
186 | struct miscdevice *miscdev = file->private_data;
| ^~
drivers/fpga/fpga-region.c:189:13: error: invalid use of undefined type 'struct file'
189 | file->private_data = region;
| ^~
drivers/fpga/fpga-region.c: In function 'fpga_region_device_ioctl':
drivers/fpga/fpga-region.c:205:66: error: invalid use of undefined type 'struct file'
205 | struct fpga_region *region = (struct fpga_region *)(file->private_data);
| ^~
>> drivers/fpga/fpga-region.c:209:21: error: implicit declaration of function 'copy_from_user' [-Wimplicit-function-declaration]
209 | if (copy_from_user(&config_info, argp, sizeof(struct fpga_region_config_info)))
| ^~~~~~~~~~~~~~
>> drivers/fpga/fpga-region.c:227:21: error: implicit declaration of function 'copy_to_user' [-Wimplicit-function-declaration]
227 | if (copy_to_user((void __user *)arg, &status, sizeof(status)))
| ^~~~~~~~~~~~
drivers/fpga/fpga-region.c: At top level:
>> drivers/fpga/fpga-region.c:237:21: error: variable 'fpga_region_fops' has initializer but incomplete type
237 | static const struct file_operations fpga_region_fops = {
| ^~~~~~~~~~~~~~~
>> drivers/fpga/fpga-region.c:238:10: error: 'const struct file_operations' has no member named 'owner'
238 | .owner = THIS_MODULE,
| ^~~~~
In file included from include/linux/printk.h:6,
from include/asm-generic/bug.h:22,
from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/current.h:6,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/fpga/fpga-bridge.h:6,
from drivers/fpga/fpga-region.c:8:
include/linux/init.h:180:21: warning: excess elements in struct initializer
180 | #define THIS_MODULE (&__this_module)
| ^
drivers/fpga/fpga-region.c:238:27: note: in expansion of macro 'THIS_MODULE'
238 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
include/linux/init.h:180:21: note: (near initialization for 'fpga_region_fops')
180 | #define THIS_MODULE (&__this_module)
| ^
drivers/fpga/fpga-region.c:238:27: note: in expansion of macro 'THIS_MODULE'
238 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
>> drivers/fpga/fpga-region.c:239:10: error: 'const struct file_operations' has no member named 'open'
239 | .open = fpga_region_device_open,
| ^~~~
>> drivers/fpga/fpga-region.c:239:27: warning: excess elements in struct initializer
239 | .open = fpga_region_device_open,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/fpga/fpga-region.c:239:27: note: (near initialization for 'fpga_region_fops')
>> drivers/fpga/fpga-region.c:240:10: error: 'const struct file_operations' has no member named 'release'
240 | .release = fpga_region_device_release,
| ^~~~~~~
drivers/fpga/fpga-region.c:240:27: warning: excess elements in struct initializer
240 | .release = fpga_region_device_release,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/fpga/fpga-region.c:240:27: note: (near initialization for 'fpga_region_fops')
>> drivers/fpga/fpga-region.c:241:10: error: 'const struct file_operations' has no member named 'unlocked_ioctl'
241 | .unlocked_ioctl = fpga_region_device_ioctl,
| ^~~~~~~~~~~~~~
drivers/fpga/fpga-region.c:241:27: warning: excess elements in struct initializer
241 | .unlocked_ioctl = fpga_region_device_ioctl,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/fpga/fpga-region.c:241:27: note: (near initialization for 'fpga_region_fops')
>> drivers/fpga/fpga-region.c:242:10: error: 'const struct file_operations' has no member named 'compat_ioctl'
242 | .compat_ioctl = fpga_region_device_ioctl,
| ^~~~~~~~~~~~
drivers/fpga/fpga-region.c:242:27: warning: excess elements in struct initializer
242 | .compat_ioctl = fpga_region_device_ioctl,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/fpga/fpga-region.c:242:27: note: (near initialization for 'fpga_region_fops')
>> drivers/fpga/fpga-region.c:237:37: error: storage size of 'fpga_region_fops' isn't known
237 | static const struct file_operations fpga_region_fops = {
| ^~~~~~~~~~~~~~~~
--
>> drivers/fpga/of-fpga-region.c:35: warning: Excess struct member 'path' description in 'of_fpga_region_priv'
vim +186 drivers/fpga/fpga-region.c
183
184 static int fpga_region_device_open(struct inode *inode, struct file *file)
185 {
> 186 struct miscdevice *miscdev = file->private_data;
187 struct fpga_region *region = container_of(miscdev, struct fpga_region, miscdev);
188
> 189 file->private_data = region;
190
191 return 0;
192 }
193
194 static int fpga_region_device_release(struct inode *inode, struct file *file)
195 {
196 return 0;
197 }
198
199 static long fpga_region_device_ioctl(struct file *file, unsigned int cmd,
200 unsigned long arg)
201 {
202 int err;
203 void __user *argp = (void __user *)arg;
204 struct fpga_region_config_info config_info;
> 205 struct fpga_region *region = (struct fpga_region *)(file->private_data);
206
207 switch (cmd) {
208 case FPGA_REGION_IOCTL_LOAD:
> 209 if (copy_from_user(&config_info, argp, sizeof(struct fpga_region_config_info)))
210 return -EFAULT;
211
212 err = region->region_ops->region_config_enumeration(region, &config_info);
213
214 break;
215 case FPGA_REGION_IOCTL_REMOVE:
216 if (copy_from_user(&config_info, argp, sizeof(struct fpga_region_config_info)))
217 return -EFAULT;
218
219 err = region->region_ops->region_remove(region, &config_info);
220
221 break;
222 case FPGA_REGION_IOCTL_STATUS:
223 unsigned int status;
224
225 status = region->region_ops->region_status(region);
226
> 227 if (copy_to_user((void __user *)arg, &status, sizeof(status)))
228 err = -EFAULT;
229 break;
230 default:
231 err = -ENOTTY;
232 }
233
234 return err;
235 }
236
> 237 static const struct file_operations fpga_region_fops = {
> 238 .owner = THIS_MODULE,
> 239 .open = fpga_region_device_open,
> 240 .release = fpga_region_device_release,
> 241 .unlocked_ioctl = fpga_region_device_ioctl,
> 242 .compat_ioctl = fpga_region_device_ioctl,
243 };
244
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-01 0:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 9:17 [RFC v2 0/1]Add user space interaction for FPGA programming Nava kishore Manne
2024-10-29 9:17 ` [RFC v2 1/1] fpga-region: Add generic IOCTL interface for runtime " Nava kishore Manne
2024-11-01 0:24 ` kernel test robot [this message]
2024-11-01 4:14 ` kernel test robot
2024-11-19 4:14 ` Xu Yilun
2024-11-21 10:07 ` Manne, Nava kishore
2024-11-27 1:49 ` Xu Yilun
2024-12-04 6:40 ` Manne, Nava kishore
2024-12-10 9:03 ` Xu Yilun
2024-12-19 9:47 ` Manne, Nava kishore
2023-03-19 15:38 ` Xu Yilun
2025-02-11 11:50 ` Manne, Nava kishore
2024-11-25 11:26 ` Marco Pagani
2024-11-28 1:34 ` Xu Yilun
2025-01-26 21:13 ` Marco Pagani
2025-02-06 6:04 ` Xu Yilun
2025-02-17 15:18 ` Marco Pagani
2025-03-01 9:27 ` Xu Yilun
2025-03-16 21:55 ` Marco Pagani
2025-03-17 6:08 ` Xu Yilun
2025-03-17 21:12 ` Arnd Bergmann
2024-11-18 6:11 ` [RFC v2 0/1]Add user space interaction for " Manne, Nava kishore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411010840.d7asQAT3-lkp@intel.com \
--to=lkp@intel.com \
--cc=nava.kishore.manne@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.