From: Jakub Kicinski <kuba@kernel.org>
To: Lei Wei <quic_leiwei@quicinc.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_kkumarcs@quicinc.com,
quic_suruchia@quicinc.com, quic_pavir@quicinc.com,
quic_linchen@quicinc.com, quic_luoj@quicinc.com,
srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org,
vsmuthu@qti.qualcomm.com, john@phrozen.org
Subject: Re: [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574
Date: Fri, 1 Nov 2024 09:31:32 -0700 [thread overview]
Message-ID: <20241101093132.7770799c@kernel.org> (raw)
In-Reply-To: <d7782a5e-2f67-4f62-a594-0f52144a368f@lunn.ch>
On Fri, 1 Nov 2024 14:21:24 +0100 Andrew Lunn wrote:
> > + /* Access to PCS registers such as PCS_MODE_CTRL which are
> > + * common to all MIIs, is lock protected and configured
> > + * only once. This is required only for interface modes
> > + * such as QSGMII.
> > + */
> > + if (interface == PHY_INTERFACE_MODE_QSGMII)
> > + mutex_lock(&qpcs->config_lock);
>
> Is there a lot of contention on this lock? Why not take it for every
> interface mode? It would make the code simpler.
+1
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-01 16:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 10:32 [PATCH net-next 0/5] Add PCS support for Qualcomm IPQ9574 SoC Lei Wei
2024-11-01 10:32 ` [PATCH net-next 1/5] dt-bindings: net: pcs: Add Ethernet PCS " Lei Wei
2024-11-02 13:34 ` Krzysztof Kozlowski
2024-11-04 11:01 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 2/5] net: pcs: Add PCS driver " Lei Wei
2024-11-01 13:00 ` Andrew Lunn
2024-11-04 11:14 ` Lei Wei
2024-11-04 13:43 ` Andrew Lunn
2024-11-07 12:12 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574 Lei Wei
2024-11-01 13:21 ` Andrew Lunn
2024-11-01 16:31 ` Jakub Kicinski [this message]
2024-11-06 3:16 ` Lei Wei
2024-11-06 3:43 ` Andrew Lunn
2024-11-08 11:31 ` Lei Wei
2024-11-08 11:37 ` Russell King (Oracle)
2024-11-08 13:24 ` Andrew Lunn
2024-11-12 12:48 ` Lei Wei
2024-11-07 19:02 ` Russell King (Oracle)
2024-11-08 12:03 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 4/5] net: pcs: qcom-ipq: Add USXGMII interface mode " Lei Wei
2024-11-01 10:32 ` [PATCH net-next 5/5] MAINTAINERS: Add maintainer for Qualcomm IPQ PCS driver Lei Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101093132.7770799c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vsmuthu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.