From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: buildroot@buildroot.org,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Raphael Pavlidis <raphael.pavlidis@gmail.com>,
Bernd Kuhls <bernd@kuhls.net>, Sen Hastings <sen@hastings.org>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Adrian Perez de Castro <aperez@igalia.com>,
Romain Naour <romain.naour@gmail.com>,
linux-amarula@amarulasolutions.com,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Norbert Lange <nolange79@gmail.com>
Subject: Re: [Buildroot] [RFC PATCH 1/2] toolchain: add BR2_TOOLCHAIN_HAS_ATOMIC_TEST_AND_SET option
Date: Fri, 1 Nov 2024 09:58:05 +0100 [thread overview]
Message-ID: <20241101095805.2929e701@windsurf> (raw)
In-Reply-To: <20241003162629.470273-1-dario.binacchi@amarulasolutions.com>
On Thu, 3 Oct 2024 18:26:28 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The build of libcap fails for ARC Targets which don't have the
> ATOMICS_EXT flag set:
>
> configure:5053: checking for cap_set_proc in -lcap
>
> cap_proc.c:(.text+0x78): undefined reference to `__atomic_test_and_set'
>
> configure:5086: result: no
> configure:5097: error: libcap support was requested but the library was not found
>
> The patch disables BR2_TOOLCHAIN_HAS_ATOMIC_TEST_AND_SET for BR2_arc
> without BR2_ARC_ATOMIC_EXT.
>
> Fixes:
> - http://autobuild.buildroot.net/results/66ee26677777124eafb4740a3c7437e06f704f98
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> toolchain/Config.in | 5 +++++
> 1 file changed, 5 insertions(+)
Thanks for the patch, but I'm afraid this is not the right approach. We
don't want to have BR2_* options for each and every atomic_* function.
We already have BR2_TOOLCHAIN_HAS_ATOMIC which serves this purpose.
However, what you need to make sure is to link against libatomic. Could
you try this instead?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-11-01 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:26 [Buildroot] [RFC PATCH 1/2] toolchain: add BR2_TOOLCHAIN_HAS_ATOMIC_TEST_AND_SET option Dario Binacchi
2024-10-03 16:26 ` [Buildroot] [RFC PATCH 2/2] package/libcap: fix build failure on ARC targets Dario Binacchi
2024-11-01 8:58 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101095805.2929e701@windsurf \
--to=buildroot@buildroot.org \
--cc=aperez@igalia.com \
--cc=bernd@kuhls.net \
--cc=dario.binacchi@amarulasolutions.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=marcus.folkesson@gmail.com \
--cc=nolange79@gmail.com \
--cc=raphael.pavlidis@gmail.com \
--cc=romain.naour@gmail.com \
--cc=sen@hastings.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.