From: kernel test robot <lkp@intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC 07/10] sysfs: drop callback bin_attribute::llseek
Date: Fri, 1 Nov 2024 13:17:30 +0800 [thread overview]
Message-ID: <202411011352.bJ3MT1ra-lkp@intel.com> (raw)
In-Reply-To: <20241031-sysfs-const-bin_attr-v1-7-2281afa7f055@weissschuh.net>
Hi Thomas,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on e42b1a9a2557aa94fee47f078633677198386a52]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/sysfs-explicitly-pass-size-to-sysfs_add_bin_file_mode_ns/20241031-104710
base: e42b1a9a2557aa94fee47f078633677198386a52
patch link: https://lore.kernel.org/r/20241031-sysfs-const-bin_attr-v1-7-2281afa7f055%40weissschuh.net
patch subject: [PATCH RFC 07/10] sysfs: drop callback bin_attribute::llseek
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241101/202411011352.bJ3MT1ra-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241101/202411011352.bJ3MT1ra-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411011352.bJ3MT1ra-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/pci/pci-sysfs.c:18:
In file included from include/linux/pci.h:1650:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/pci-sysfs.c:1202:13: error: no member named 'llseek' in 'struct bin_attribute'
1202 | res_attr->llseek = pci_llseek_resource;
| ~~~~~~~~ ^
4 warnings and 1 error generated.
vim +1202 drivers/pci/pci-sysfs.c
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1165
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1166 static int pci_create_attr(struct pci_dev *pdev, int num, int write_combine)
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1167 {
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1168 /* allocate attribute structure, piggyback attribute name */
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1169 int name_len = write_combine ? 13 : 10;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1170 struct bin_attribute *res_attr;
bd5174dfb6f171 Bjorn Helgaas 2016-03-10 1171 char *res_attr_name;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1172 int retval;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1173
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1174 res_attr = kzalloc(sizeof(*res_attr) + name_len, GFP_ATOMIC);
bd5174dfb6f171 Bjorn Helgaas 2016-03-10 1175 if (!res_attr)
bd5174dfb6f171 Bjorn Helgaas 2016-03-10 1176 return -ENOMEM;
bd5174dfb6f171 Bjorn Helgaas 2016-03-10 1177
bd5174dfb6f171 Bjorn Helgaas 2016-03-10 1178 res_attr_name = (char *)(res_attr + 1);
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1179
a07e4156a2ee63 Eric W. Biederman 2010-02-11 1180 sysfs_bin_attr_init(res_attr);
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1181 if (write_combine) {
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1182 sprintf(res_attr_name, "resource%d_wc", num);
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1183 res_attr->mmap = pci_mmap_resource_wc;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1184 } else {
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1185 sprintf(res_attr_name, "resource%d", num);
8633328be24267 Alex Williamson 2010-07-19 1186 if (pci_resource_flags(pdev, num) & IORESOURCE_IO) {
8633328be24267 Alex Williamson 2010-07-19 1187 res_attr->read = pci_read_resource_io;
8633328be24267 Alex Williamson 2010-07-19 1188 res_attr->write = pci_write_resource_io;
e854d8b2a82ef7 David Woodhouse 2017-04-12 1189 if (arch_can_pci_mmap_io())
e854d8b2a82ef7 David Woodhouse 2017-04-12 1190 res_attr->mmap = pci_mmap_resource_uc;
e854d8b2a82ef7 David Woodhouse 2017-04-12 1191 } else {
e854d8b2a82ef7 David Woodhouse 2017-04-12 1192 res_attr->mmap = pci_mmap_resource_uc;
e854d8b2a82ef7 David Woodhouse 2017-04-12 1193 }
8633328be24267 Alex Williamson 2010-07-19 1194 }
24de09c16f974d Valentine Sinitsyn 2023-09-25 1195 if (res_attr->mmap) {
f06aff924f9758 Krzysztof Wilczyński 2021-07-29 1196 res_attr->f_mapping = iomem_get_mapping;
24de09c16f974d Valentine Sinitsyn 2023-09-25 1197 /*
24de09c16f974d Valentine Sinitsyn 2023-09-25 1198 * generic_file_llseek() consults f_mapping->host to determine
24de09c16f974d Valentine Sinitsyn 2023-09-25 1199 * the file size. As iomem_inode knows nothing about the
24de09c16f974d Valentine Sinitsyn 2023-09-25 1200 * attribute, it's not going to work, so override it as well.
24de09c16f974d Valentine Sinitsyn 2023-09-25 1201 */
24de09c16f974d Valentine Sinitsyn 2023-09-25 @1202 res_attr->llseek = pci_llseek_resource;
24de09c16f974d Valentine Sinitsyn 2023-09-25 1203 }
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1204 res_attr->attr.name = res_attr_name;
e2154044dd4168 Kelsey Skunberg 2019-08-13 1205 res_attr->attr.mode = 0600;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1206 res_attr->size = pci_resource_len(pdev, num);
dca40b186b757c David Woodhouse 2017-04-12 1207 res_attr->private = (void *)(unsigned long)num;
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1208 retval = sysfs_create_bin_file(&pdev->dev.kobj, res_attr);
aa382ffa705bea Sascha Hauer 2022-11-08 1209 if (retval) {
b562ec8f74e4ed Bjorn Helgaas 2016-03-10 1210 kfree(res_attr);
45aec1ae72fc59 venkatesh.pallipadi@intel.com 2008-03-18 1211 return retval;
b19441af185559 Greg Kroah-Hartman 2006-08-28 1212 }
b19441af185559 Greg Kroah-Hartman 2006-08-28 1213
aa382ffa705bea Sascha Hauer 2022-11-08 1214 if (write_combine)
aa382ffa705bea Sascha Hauer 2022-11-08 1215 pdev->res_attr_wc[num] = res_attr;
aa382ffa705bea Sascha Hauer 2022-11-08 1216 else
aa382ffa705bea Sascha Hauer 2022-11-08 1217 pdev->res_attr[num] = res_attr;
aa382ffa705bea Sascha Hauer 2022-11-08 1218
aa382ffa705bea Sascha Hauer 2022-11-08 1219 return 0;
aa382ffa705bea Sascha Hauer 2022-11-08 1220 }
aa382ffa705bea Sascha Hauer 2022-11-08 1221
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-01 5:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 2:43 [PATCH RFC 00/10] sysfs: constify struct bin_attribute (Part 1) Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 01/10] sysfs: explicitly pass size to sysfs_add_bin_file_mode_ns() Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 02/10] sysfs: introduce callback attribute_group::bin_size Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 03/10] PCI/sysfs: Calculate bin_attribute size through bin_size() Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 04/10] nvmem: core: calculate " Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 05/10] sysfs: treewide: constify attribute callback of bin_is_visible() Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 06/10] sysfs: treewide: constify attribute callback of bin_attribute::mmap() Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 07/10] sysfs: drop callback bin_attribute::llseek Thomas Weißschuh
2024-11-01 5:17 ` kernel test robot [this message]
2024-11-01 5:27 ` kernel test robot
2024-10-31 2:43 ` [PATCH RFC 08/10] sysfs: implement all BIN_ATTR_* macros in terms of __BIN_ATTR() Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 09/10] sysfs: bin_attribute: add const read/write callback variants Thomas Weißschuh
2024-10-31 2:43 ` [PATCH RFC 10/10] driver core: Constify attribute arguments of binary attributes Thomas Weißschuh
2024-11-01 1:20 ` [PATCH RFC 00/10] sysfs: constify struct bin_attribute (Part 1) Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411011352.bJ3MT1ra-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux@weissschuh.net \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.