Re: [PATCH v4 4/4] ext4: Do not fallback to buffered-io for DIO atomic write

[kernel test robot <lkp@intel.com>]

Hi Ritesh,

kernel test robot noticed the following build errors:

[auto build test ERROR on tytso-ext4/dev]
[also build test ERROR on linus/master v6.12-rc5 next-20241101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ritesh-Harjani-IBM/ext4-Add-statx-support-for-atomic-writes/20241101-145608
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link:    https://lore.kernel.org/r/78fb5c40dde4847dc32af09e668a6f81fa251137.1730437365.git.ritesh.list%40gmail.com
patch subject: [PATCH v4 4/4] ext4: Do not fallback to buffered-io for DIO atomic write
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241102/202411021812.J6p7IRRP-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411021812.J6p7IRRP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411021812.J6p7IRRP-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from fs/ext4/inode.c:26:
   In file included from include/linux/pagemap.h:8:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> fs/ext4/inode.c:3455:14: error: use of undeclared identifier 'IOMAP_ATOMIC'
    3455 |         if (flags & IOMAP_ATOMIC)
         |                     ^
   4 warnings and 1 error generated.


vim +/IOMAP_ATOMIC +3455 fs/ext4/inode.c

  3446	
  3447	static inline bool ext4_want_directio_fallback(unsigned flags, ssize_t written)
  3448	{
  3449		/* must be a directio to fall back to buffered */
  3450		if ((flags & (IOMAP_WRITE | IOMAP_DIRECT)) !=
  3451			    (IOMAP_WRITE | IOMAP_DIRECT))
  3452			return false;
  3453	
  3454		/* atomic writes are all-or-nothing */
> 3455		if (flags & IOMAP_ATOMIC)
  3456			return false;
  3457	
  3458		/* can only try again if we wrote nothing */
  3459		return written == 0;
  3460	}
  3461	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki