From: Jakub Kicinski <kuba@kernel.org>
To: Gur Stavi <gur.stavi@huawei.com>
Cc: 'Andrew Lunn' <andrew@lunn.ch>,
"Gongfan (Eric, Chip)" <gongfan1@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
"Guoxin (D)" <guoxin09@huawei.com>,
shenchenyang <shenchenyang1@hisilicon.com>,
"zhoushuai (A)" <zhoushuai28@huawei.com>,
"Wulike (Collin)" <wulike1@huawei.com>,
"shijing (A)" <shijing34@huawei.com>,
Meny Yossefi <meny.yossefi@huawei.com>
Subject: Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC
Date: Sun, 3 Nov 2024 14:19:30 -0800 [thread overview]
Message-ID: <20241103141930.271ea070@kernel.org> (raw)
In-Reply-To: <000201db2e2d$82ad67d0$88083770$@huawei.com>
On Sun, 3 Nov 2024 22:17:55 +0200 Gur Stavi wrote:
> Breaking a 10KLoC submission into a few 4KLcC (or less) patches helps to
> review specific patches (and ignore other patches) but all lines still need
> to be approved at once so someone must review them.
>
> Breaking 10KLoC into multiple submissions is easier to review and approve
> (in parts), but merged code will be non-functional until the last
> submission.
> It will compile fine, do no harm, and nobody will pick it except for allyes
> builds.
The driver not being fully functional after the first submission is
fine.
This is a better example, although some parts could have still be
delayed to the second chunk:
https://lore.kernel.org/all/172054602727.1305884.10973465571854855750.stgit@ahduyck-xeon-server.home.arpa/
next prev parent reply other threads:[~2024-11-03 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:25 [RFC net-next v01 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2024-10-30 12:25 ` [RFC net-next v01 1/1] " Gur Stavi
2024-11-01 2:35 ` Jakub Kicinski
2024-11-03 12:29 ` Gur Stavi
2024-11-03 18:54 ` Andrew Lunn
2024-11-03 20:17 ` Gur Stavi
2024-11-03 21:19 ` Andrew Lunn
2024-11-03 22:19 ` Jakub Kicinski [this message]
2024-11-02 8:00 ` kernel test robot
2024-11-02 8:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103141930.271ea070@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.