From: Jakub Kicinski <kuba@kernel.org>
To: Suraj Gupta <suraj.gupta2@amd.com>
Cc: <radhey.shyam.pandey@amd.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<michal.simek@amd.com>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <git@amd.com>,
<harini.katakam@amd.com>
Subject: Re: [PATCH net 2/2] net: xilinx: axienet: Check if Tx queue enabled
Date: Sun, 3 Nov 2024 14:37:00 -0800 [thread overview]
Message-ID: <20241103143700.3ce70273@kernel.org> (raw)
In-Reply-To: <20241030062533.2527042-3-suraj.gupta2@amd.com>
On Wed, 30 Oct 2024 11:55:33 +0530 Suraj Gupta wrote:
> Check return value of netif_txq_maybe_stop() in transmit
> direction and start dma engine only if queue is enabled.
The first patch makes sense, let me apply that one.
But this one I don't understand - what is the problem you're trying
to fix? netif_txq_maybe_stop() tries to stop the queue if the *next*
packet may not fit in the queue. The currently processed packet is
assumed to have already been queued.
next prev parent reply other threads:[~2024-11-03 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 6:25 [PATCH net 0/2] net: xilinx: axienet: Fix kernel crash in dmaengine transmit path Suraj Gupta
2024-10-30 6:25 ` [PATCH net 1/2] net: xilinx: axienet: Enqueue Tx packets in dql before dmaengine starts Suraj Gupta
2024-10-30 6:25 ` [PATCH net 2/2] net: xilinx: axienet: Check if Tx queue enabled Suraj Gupta
2024-11-03 22:37 ` Jakub Kicinski [this message]
2024-11-04 7:08 ` Gupta, Suraj
2024-11-03 22:50 ` [PATCH net 0/2] net: xilinx: axienet: Fix kernel crash in dmaengine transmit path patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103143700.3ce70273@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.