From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com
Subject: Re: [PATCH 3/3] xfs: port ondisk structure checks from xfs/122 to the kernel
Date: Mon, 4 Nov 2024 05:29:04 +0100 [thread overview]
Message-ID: <20241104042904.GC17773@lst.de> (raw)
In-Reply-To: <173049942802.1909552.3233838341241015760.stgit@frogsfrogsfrogs>
On Fri, Nov 01, 2024 at 03:19:05PM -0700, Darrick J. Wong wrote:
> +#define XFS_CHECK_SB_OFFSET(field, offset) \
> + XFS_CHECK_OFFSET(struct xfs_dsb, field, offset); \
> + XFS_CHECK_OFFSET(struct xfs_sb, field, offset);
Despite comments to the contrary, xfs_sb is purely an in-memory structure
and nothing cares about it having the same layout as xfs_dsb. As we've
kept them in sync so far I'm fine with adding this check under the
expectation that I can remove it again when I finally start removing
struct xfs_sb, which is long overdue.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-11-04 4:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 22:18 [PATCHSET v5.4] xfs: improve ondisk structure checks Darrick J. Wong
2024-11-01 22:18 ` [PATCH 1/3] xfs: convert struct typedefs in xfs_ondisk.h Darrick J. Wong
2024-11-04 4:26 ` Christoph Hellwig
2024-11-01 22:18 ` [PATCH 2/3] xfs: separate space btree structures " Darrick J. Wong
2024-11-04 4:26 ` Christoph Hellwig
2024-11-01 22:19 ` [PATCH 3/3] xfs: port ondisk structure checks from xfs/122 to the kernel Darrick J. Wong
2024-11-04 4:29 ` Christoph Hellwig [this message]
2024-11-04 5:09 ` Darrick J. Wong
2024-11-05 12:57 ` [PATCHSET v5.4] xfs: improve ondisk structure checks Carlos Maiolino
2024-11-05 15:41 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-11-05 22:06 [PATCHSET v5.5 10/10] " Darrick J. Wong
2024-11-05 22:42 ` [PATCH 3/3] xfs: port ondisk structure checks from xfs/122 to the kernel Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104042904.GC17773@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.