From: Herve Codina <herve.codina@bootlin.com>
To: Andrea della Porta <andrea.porta@suse.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Krzysztof Wilczynski <kw@linux.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-gpio@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes
Date: Mon, 4 Nov 2024 09:06:23 +0100 [thread overview]
Message-ID: <20241104090623.53f73d75@bootlin.com> (raw)
In-Reply-To: <f6b445b764312fd8ab96745fe4e97fb22f91ae4c.1730123575.git.andrea.porta@suse.com>
Hi Andrea,
On Mon, 28 Oct 2024 15:07:22 +0100
Andrea della Porta <andrea.porta@suse.com> wrote:
> When populating "ranges" property for a PCI bridge, of_pci_prop_ranges()
> incorrectly use the CPU bus address of the resource. Since this is a PCI-PCI
> bridge, the window should instead be in PCI address space. Call
> pci_bus_address() on the resource in order to obtain the PCI bus
> address.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
Tested ok with my LAN966x PCI device.
Tested-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2024-11-04 8:10 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 14:07 [PATCH v3 00/12] Add support for RaspberryPi RP1 PCI device using a DT overlay Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 01/12] dt-bindings: clock: Add RaspberryPi RP1 clock bindings Andrea della Porta
2024-10-28 14:21 ` Krzysztof Kozlowski
2024-10-29 7:23 ` Krzysztof Kozlowski
2024-10-31 9:16 ` Andrea della Porta
2024-11-15 11:31 ` Andrea della Porta
2024-11-15 23:00 ` Stephen Boyd
2024-10-28 14:07 ` [PATCH v3 02/12] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings Andrea della Porta
2024-10-29 7:26 ` Krzysztof Kozlowski
2024-10-31 14:07 ` Andrea della Porta
2024-10-31 18:10 ` Krzysztof Kozlowski
2024-11-04 11:11 ` Andrea della Porta
2024-11-07 11:57 ` Krzysztof Kozlowski
2024-10-28 14:07 ` [PATCH v3 03/12] dt-bindings: pci: Add common schema for devices accessible through PCI BARs Andrea della Porta
2024-10-29 7:28 ` Krzysztof Kozlowski
2024-10-31 14:20 ` Andrea della Porta
2024-10-31 18:06 ` Krzysztof Kozlowski
2024-11-04 11:18 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 04/12] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1 Andrea della Porta
2024-11-06 14:50 ` Manivannan Sadhasivam
2024-11-07 7:17 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes Andrea della Porta
2024-10-28 16:57 ` Bjorn Helgaas
2024-11-02 17:09 ` Manivannan Sadhasivam
2024-11-04 8:54 ` Andrea della Porta
2024-11-04 15:05 ` Manivannan Sadhasivam
2024-11-04 23:49 ` Bjorn Helgaas
2024-11-06 14:35 ` Manivannan Sadhasivam
2024-11-07 9:06 ` Andrea della Porta
2024-11-07 10:48 ` Manivannan Sadhasivam
2024-11-07 11:51 ` Stanimir Varbanov
2024-11-04 8:06 ` Herve Codina [this message]
2024-11-04 8:38 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 06/12] of: address: Preserve the flags portion on 1:1 dma-ranges mapping Andrea della Porta
2024-11-04 8:08 ` Herve Codina
2024-10-28 14:07 ` [PATCH v3 07/12] clk: rp1: Add support for clocks provided by RP1 Andrea della Porta
2024-10-28 22:20 ` Stephen Boyd
2024-11-05 8:30 ` Andrea della Porta
2024-10-31 12:07 ` kernel test robot
2024-10-31 14:12 ` kernel test robot
2024-11-01 4:14 ` kernel test robot
2024-10-28 14:07 ` [PATCH v3 08/12] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Andrea della Porta
2024-10-28 22:16 ` Linus Walleij
2024-10-28 22:18 ` Linus Walleij
2024-10-31 14:44 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 09/12] arm64: dts: rp1: Add support for RaspberryPi's RP1 device Andrea della Porta
2024-11-04 13:29 ` Stanimir Varbanov
2024-11-05 14:31 ` Andrea della Porta
2024-11-06 12:28 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 10/12] misc: rp1: RaspberryPi RP1 misc driver Andrea della Porta
2024-11-04 13:43 ` Stanimir Varbanov
2024-11-05 15:53 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 11/12] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Andrea della Porta
2024-10-28 20:49 ` Stephen Boyd
2024-10-31 14:46 ` Andrea della Porta
2024-10-28 14:07 ` [PATCH v3 12/12] arm64: defconfig: Enable RP1 misc/clock/gpio drivers Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104090623.53f73d75@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=andrea.porta@suse.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=masahiroy@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wahrenst@gmx.net \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.