All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Chen Haixiang <chenhaixiang3@huawei.com>
Cc: kexec@lists.infradead.org, louhongxiang@huawei.com,
	wangbin224@huawei.com, yangyanchao6@huawei.com
Subject: Re: [PATCH v2] Before adding to usablemem_rgns, check if the memory range is already included.
Date: Mon, 4 Nov 2024 09:29:28 +0000	[thread overview]
Message-ID: <20241104092928.GR1838431@kernel.org> (raw)
In-Reply-To: <20241021120025.1430-1-chenhaixiang3@huawei.com>

On Mon, Oct 21, 2024 at 08:00:25PM +0800, Chen Haixiang wrote:
> When kexec_iomem_for_each_line() reads from /proc/iomem,
> concurrent modifications to /proc/iomem may lead to
> usablemem_rgns recording duplicate Crash kernel segments.
> This can result in the number of retrieved Crash kernel
> segments exceeding CRASH_MAX_RESERVED_RANGES, triggering
> a realloc of the crash_reserved_mem in usablemem_rgns,
> which could crash the process. We should ensure that each
> range added to usablemem_rgns is unique to prevent these issues.
> 
> Reviewed-by: Louhongxiang <louhongxiang@huawei.com>
> Reviewed-by: wangbin <wangbin224@huawei.com>
> Reviewed-by: yangyanchao <yangyanchao6@huawei.com>
> Signed-off-by: chenhaixiang <chenhaixiang3@huawei.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2024-11-04  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 12:00 [PATCH v2] Before adding to usablemem_rgns, check if the memory range is already included Chen Haixiang
2024-11-04  9:29 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241104092928.GR1838431@kernel.org \
    --to=horms@kernel.org \
    --cc=chenhaixiang3@huawei.com \
    --cc=kexec@lists.infradead.org \
    --cc=louhongxiang@huawei.com \
    --cc=wangbin224@huawei.com \
    --cc=yangyanchao6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.