From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3951A1B86CC; Mon, 4 Nov 2024 10:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730717569; cv=none; b=sNoL7h3efpHGskLUUlwk7vbuya0iQnAi67dQbULlE0FiTJhMaURdS9KLg1KqPdDBa/1IbfvoWjf685azm5lrWg29rAfXyN5rje7VnOKq/7ijtXWdwcjRVjPKLdrdp70BrG4jHDTHFNYc+Si6IMrym0U5Zc8cAbR+90RI64XFH7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730717569; c=relaxed/simple; bh=MxfQoHMFK+WwVWQyVLXYG2MTtBcOuGGA3HeitR9zf3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jaARPW5LnWMcZzbLdERaOduzGYLkF6N+84eGL6HLNYdDbffKpgH8YzO7N1keX/1Q+reoQ1OqQmSVZ1CTANpl+l1VCH+ghzjPBZvxc5Z+6+g1dEe73YtLYXXfaXJNJ/sbNxs44e7539MO5FpD2xu7JxBkgHvtHSrcGpYdTYMl98w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7ZpSe9/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7ZpSe9/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EACCC4CECE; Mon, 4 Nov 2024 10:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730717568; bh=MxfQoHMFK+WwVWQyVLXYG2MTtBcOuGGA3HeitR9zf3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P7ZpSe9/NRnn796p2dydGbBlV0th076lIRafztLzwDIN8XG8L0XgjatUm2ANI6RHT FPtnCtw/+04psLjaNw9n281kgVEKBzNLPazCz18Dk6tyNQLTCKi7HWX/pIdCNGvOZI Jsv22MpZVBaCg5BnMkP/Zu5fDsMoK31uE8+Wc59JqXpOcXZ65dYIOwUMtJATluI2bD V603MavQmrMbSimqSRm9LL2sK+fsUVNbBRACdinjYg0L8BcNlLJK7IKKxfBxVhr71i 4ebvSTAYixvn9VIwLzkge5xGY7HH7aNM4qLJPj6yzRCFb0yoJ7bqZeBBQ6e9dvxSso yqUVYlxIqhlxQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Gabay , Miri Korenblit , Johannes Berg , Sasha Levin , kvalo@kernel.org, shaul.triebitz@intel.com, gregory.greenman@intel.com, yedidya.ben.shimol@intel.com, benjamin.berg@intel.com, emmanuel.grumbach@intel.com, linux-wireless@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 06/14] wifi: iwlwifi: mvm: Use the sync timepoint API in suspend Date: Mon, 4 Nov 2024 05:51:58 -0500 Message-ID: <20241104105228.97053-6-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241104105228.97053-1-sashal@kernel.org> References: <20241104105228.97053-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.59 Content-Transfer-Encoding: 8bit From: Daniel Gabay [ Upstream commit 9715246ca0bfc9feaec1b4ff5b3d38de65a7025d ] When starting the suspend flow, HOST_D3_START triggers an _async_ firmware dump collection for debugging purposes. The async worker may race with suspend flow and fail to get NIC access, resulting in the following warning: "Timeout waiting for hardware access (CSR_GP_CNTRL 0xffffffff)" Fix this by switching to the sync version to ensure the dump completes before proceeding with the suspend flow, avoiding potential race issues. Signed-off-by: Daniel Gabay Signed-off-by: Miri Korenblit Link: https://patch.msgid.link/20241010140328.9aae318cd593.I4b322009f39489c0b1d8893495c887870f73ed9c@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/init.c | 4 +++- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/init.c b/drivers/net/wireless/intel/iwlwifi/fw/init.c index 135bd48bfe9fa..cf02a2afbee56 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/init.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/init.c @@ -39,10 +39,12 @@ void iwl_fw_runtime_init(struct iwl_fw_runtime *fwrt, struct iwl_trans *trans, } IWL_EXPORT_SYMBOL(iwl_fw_runtime_init); +/* Assumes the appropriate lock is held by the caller */ void iwl_fw_runtime_suspend(struct iwl_fw_runtime *fwrt) { iwl_fw_suspend_timestamp(fwrt); - iwl_dbg_tlv_time_point(fwrt, IWL_FW_INI_TIME_POINT_HOST_D3_START, NULL); + iwl_dbg_tlv_time_point_sync(fwrt, IWL_FW_INI_TIME_POINT_HOST_D3_START, + NULL); } IWL_EXPORT_SYMBOL(iwl_fw_runtime_suspend); diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index 08d1fab7f53c3..592b9157d50c6 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c @@ -1382,7 +1382,9 @@ int iwl_mvm_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan) iwl_mvm_pause_tcm(mvm, true); + mutex_lock(&mvm->mutex); iwl_fw_runtime_suspend(&mvm->fwrt); + mutex_unlock(&mvm->mutex); return __iwl_mvm_suspend(hw, wowlan, false); } -- 2.43.0