All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Bystrin <dev.mbstr@gmail.com>
To: git@vger.kernel.org
Subject: [RFC PATCH 0/1] git: pager behaviour
Date: Mon,  4 Nov 2024 17:05:35 +0300	[thread overview]
Message-ID: <20241104140536.4970-1-dev.mbstr@gmail.com> (raw)

I've recently discovered that launching `--edit` with `--paginate` breaks
everything. Is this an expected behaviour? I proposed a possible solution in
this patch. However it is turned out that situation with pager is more
complicated than expected.

This patch does not fix `notes` command and even does not pass "t7006.24 git tag
-a respects --paginate" test. Interesting point to mention is that `notes edit`
command can be also broken with `-c pager.notes=1`.

Relates: cd878a206e8c (t7006: add tests for how git config paginates) 

Matthew Bystrin (1):
  git: ignore paginate for commands with DELAY_PAGER_CONFIG

 git.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-11-04 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 14:05 Matthew Bystrin [this message]
2024-11-04 14:05 ` [RFC PATCH 1/1] git: ignore paginate for commands with DELAY_PAGER_CONFIG Matthew Bystrin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241104140536.4970-1-dev.mbstr@gmail.com \
    --to=dev.mbstr@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.