All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: rdbabiera@google.com, linux-usb@vger.kernel.org,
	krzk+dt@kernel.org, dmitry.baryshkov@linaro.org,
	conor+dt@kernel.org, gregkh@linuxfoundation.org,
	badhri@google.com, linux@roeck-us.net, xu.yang_2@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	heikki.krogerus@linux.intel.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	kyletso@google.com
Subject: Re: [PATCH v2 2/3] dt-bindings: usb: maxim,max33359: add usage of sink bc12 time property
Date: Mon, 4 Nov 2024 08:41:11 -0600	[thread overview]
Message-ID: <20241104144111.GA4077878-robh@kernel.org> (raw)
In-Reply-To: <173061137043.3549002.17300495931303369678.robh@kernel.org>

On Sun, Nov 03, 2024 at 12:22:50AM -0500, Rob Herring (Arm) wrote:
> 
> On Sat, 02 Nov 2024 20:43:29 -0700, Amit Sunil Dhamne wrote:
> > Add usage of "sink-bc12-completion-time-ms"  connector property to
> > max33359 controller for delaying PD negotiation till BC1.2 detection
> > completes. This overcomes the occasional delays observed while
> > receiving PD messages where BC1.2 detection runs in parallel.
> > 
> > Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> > Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: maxtcpc@25: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/usb/maxim,max33359.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb: connector: Unevaluated properties are not allowed ('sink-bc12-completion-time-ms' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/connector/usb-connector.yaml#

This can be ignored as patch 1 couldn't be applied.

Rob


  reply	other threads:[~2024-11-04 14:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03  3:43 [PATCH v2 0/3] Add new time property for battery charger type detection Amit Sunil Dhamne
2024-11-03  3:43 ` [PATCH v2 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion Amit Sunil Dhamne
2024-11-03  3:43 ` [PATCH v2 2/3] dt-bindings: usb: maxim,max33359: add usage of sink bc12 time property Amit Sunil Dhamne
2024-11-03  5:22   ` Rob Herring (Arm)
2024-11-04 14:41     ` Rob Herring [this message]
2024-11-03  3:43 ` [PATCH v2 3/3] usb: typec: tcpm: Add support for sink-bc12-completion-time-ms DT property Amit Sunil Dhamne
2024-11-14 19:59   ` Amit Sunil Dhamne
2024-11-15  7:19     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241104144111.GA4077878-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=amitsd@google.com \
    --cc=badhri@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kyletso@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rdbabiera@google.com \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.