From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch,
shuah@kernel.org, horms@kernel.org, almasrymina@google.com,
willemb@google.com, petrm@nvidia.com
Subject: Re: [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test
Date: Mon, 4 Nov 2024 17:34:03 -0800 [thread overview]
Message-ID: <20241104173403.49322788@kernel.org> (raw)
In-Reply-To: <ZyljjgxP94IBWnI6@LQ3V64L9R2>
On Mon, 4 Nov 2024 16:15:10 -0800 Joe Damato wrote:
> > + with bkg(listen_cmd) as nc:
> > + wait_port_listen(port)
> > + cmd(f"echo -e \"hello\\nworld\"| nc {cfg.v6} {port}", host=cfg.remote, shell=True)
>
> FWIW, in the v3 of the series I submit, Jakub asked me to replace nc
> with socat due to issues with nc [1].
>
> Your usage of nc seems pretty basic though, so maybe it's fine?
Good catch, let's not use nc. I seem to recall it's also funny about
address family selection. Also may be useful to add a helper for sending
simple strings from remote to avoid having this problem again.
next prev parent reply other threads:[~2024-11-05 1:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 18:14 [PATCH net-next v7 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-11-04 23:35 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-11-04 23:43 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-11-04 23:46 ` Joe Damato
2024-11-05 3:29 ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-11-04 23:48 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-11-04 23:50 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-11-04 23:55 ` Joe Damato
2024-11-05 1:54 ` Jakub Kicinski
2024-11-05 3:33 ` Stanislav Fomichev
2024-11-05 17:46 ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 07/12] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-11-04 23:56 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-11-05 0:00 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-11-05 0:01 ` Joe Damato
2024-11-04 18:14 ` [PATCH net-next v7 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-11-05 0:11 ` Joe Damato
2024-11-05 3:31 ` Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-11-04 18:14 ` [PATCH net-next v7 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev
2024-11-05 0:15 ` Joe Damato
2024-11-05 1:34 ` Jakub Kicinski [this message]
2024-11-05 3:34 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104173403.49322788@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.