All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Bakker <kees@ijzerbout.nl>
Cc: Dave Penkler <dpenkler@gmail.com>,
	Linux Staging <linux-staging@lists.linux.dev>
Subject: Re: [PATCH] staging: gpib: Change return type of fluke_get_dma_residue
Date: Mon, 4 Nov 2024 00:45:57 +0100	[thread overview]
Message-ID: <2024110442-citadel-papyrus-f8c5@gregkh> (raw)
In-Reply-To: <20241020153948.B607818CC05@bout3.ijzerbout.nl>

On Tue, Oct 15, 2024 at 10:33:30PM +0200, Kees Bakker wrote:
> The function fluke_get_dma_residue returns an error as a negative value.
> So the return type must not be unsigned.
> 
> This was detected by Coverity, CID 1600782
> 
> Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> ---
>  v1 -> v2: change type of `residue` var; add note about Coverity CID in commit message

There is no "v2" in the subject line :(

Please fix and send a v3.

thanks,

greg k-h

  reply	other threads:[~2024-11-04  5:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 20:33 [PATCH] staging: gpib: Change return type of fluke_get_dma_residue Kees Bakker
2024-11-03 23:45 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-15 20:33 Kees Bakker
2024-10-19  7:59 ` Greg KH
2024-10-19 18:19   ` Kees Bakker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024110442-citadel-papyrus-f8c5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dpenkler@gmail.com \
    --cc=kees@ijzerbout.nl \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.