From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,yosryahmed@google.com,shakeel.butt@linux.dev,roman.gushchin@linux.dev,muchun.song@linux.dev,mhocko@kernel.org,hughd@google.com,hannes@cmpxchg.org,yuzhao@google.com,akpm@linux-foundation.org
Subject: [folded-merged] memcg-v1-no-need-for-memcg-locking-for-mglru-fix.patch removed from -mm tree
Date: Mon, 04 Nov 2024 22:29:32 -0800 [thread overview]
Message-ID: <20241105062932.C985BC4CECF@smtp.kernel.org> (raw)
The quilt patch titled
Subject: memcg-v1-no-need-for-memcg-locking-for-mglru-fix
has been removed from the -mm tree. Its filename was
memcg-v1-no-need-for-memcg-locking-for-mglru-fix.patch
This patch was dropped because it was folded into memcg-v1-no-need-for-memcg-locking-for-mglru.patch
------------------------------------------------------
From: Yu Zhao <yuzhao@google.com>
Subject: memcg-v1-no-need-for-memcg-locking-for-mglru-fix
Date: Mon, 4 Nov 2024 10:30:29 -0700
remove !rcu_read_lock_held() assertion
WARNING: CPU: 0 PID: 85 at mm/vmscan.c:3140 folio_update_gen+0x23d/0x250 mm/vmscan.c:3140
...
This assertion is incorrect after this patch series that has removed the
charge migration and has removed mem_cgroup_trylock_pages() /
mem_cgroup_unlock_pages() from the caller of this function
(folio_update_gen()).
The assertion was caused by the patch in this thread. It used to assert
that a folio must be protected from charge migration. Charge migration is
removed by this series, and as part of the effort, this patch removes the
RCU lock.
Link: https://lkml.kernel.org/r/ZykEtcHrQRq-KrBC@google.com
Link: https://syzkaller.appspot.com/bug?extid=24f45b8beab9788e467e
Link: https://lore.kernel.org/lkml/67294349.050a0220.701a.0010.GAE@google.com/
Signed-off-by: Yu Zhao <yuzhao@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 1 -
1 file changed, 1 deletion(-)
--- a/mm/vmscan.c~memcg-v1-no-need-for-memcg-locking-for-mglru-fix
+++ a/mm/vmscan.c
@@ -3137,7 +3137,6 @@ static int folio_update_gen(struct folio
unsigned long new_flags, old_flags = READ_ONCE(folio->flags);
VM_WARN_ON_ONCE(gen >= MAX_NR_GENS);
- VM_WARN_ON_ONCE(!rcu_read_lock_held());
do {
/* lru_gen_del_folio() has isolated this page? */
_
Patches currently in -mm which might be from yuzhao@google.com are
mm-page_alloc-keep-track-of-free-highatomic.patch
memcg-v1-no-need-for-memcg-locking-for-mglru.patch
next reply other threads:[~2024-11-05 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 6:29 Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-04 4:58 [folded-merged] memcg-v1-no-need-for-memcg-locking-for-mglru-fix.patch removed from -mm tree Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105062932.C985BC4CECF@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=mhocko@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.