From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Howard Chu <howardchu95@gmail.com>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Thomas Richter <tmricht@linux.ibm.com>,
Veronika Molnarova <vmolnaro@redhat.com>
Subject: [PATCH v2 4/4] perf build: Emit a warning when libtraceevent is explicitely disabled
Date: Tue, 5 Nov 2024 11:26:16 -0300 [thread overview]
Message-ID: <20241105142616.761042-5-acme@kernel.org> (raw)
In-Reply-To: <20241105142616.761042-1-acme@kernel.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Since not having the libtraceevent devel package installed prevents the
build from proceeding unless NO_LIBTRACEEVENT=1 is passed:
$ make O=/tmp/build/perf-tools-next/ -C tools/perf install-bin
Makefile.config:1195: *** ERROR: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel and/or set LIBTRACEEVENT_DIR or build with NO_LIBTRACEEVENT=1. Stop.
make[1]: *** [Makefile.perf:292: sub-make] Error 2
make: *** [Makefile:119: install-bin] Error 2
make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'
$
Behave just like with the NO_LIBPYTHON case:
$ make NO_LIBPYTHON=1 NO_LIBTRACEEVENT=1 O=/tmp/build/perf-tools-next/ -C tools/perf install-bin
Makefile.config:874: Python support disabled by user
Makefile.config:1180: libtraceevent support disabled by user
Auto-detecting system features:
<SNIP>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Howard Chu <howardchu95@gmail.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linux.dev>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Veronika Molnarova <vmolnaro@redhat.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.config | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 80bf06e828f0ebc8..3ae3449ccf684b42 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -1180,7 +1180,9 @@ ifndef NO_LIBPFM4
endif
# libtraceevent is a recommended dependency picked up from the system.
-ifneq ($(NO_LIBTRACEEVENT),1)
+ifeq ($(NO_LIBTRACEEVENT),1)
+ msg := $(warning libtraceevent support disabled by user);
+else
$(call feature_check,libtraceevent)
ifeq ($(feature-libtraceevent), 1)
CFLAGS += -DHAVE_LIBTRACEEVENT $(shell $(PKG_CONFIG) --cflags libtraceevent)
--
2.47.0
prev parent reply other threads:[~2024-11-05 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 14:26 [PATCH v2 perf-tools-next 0/4] 'perf test' fixes/improvements Arnaldo Carvalho de Melo
2024-11-05 14:26 ` [PATCH v2 1/4] perf test python: Robustify the 'perf test python' test case Arnaldo Carvalho de Melo
2024-11-05 14:26 ` [PATCH v2 2/4] perf test: Skip the python binding builtin test case with NO_LIBPYTHON=1 Arnaldo Carvalho de Melo
2024-11-05 14:26 ` [PATCH v2 3/4] perf test: Don't suppress the libtraceevent tests, skip them Arnaldo Carvalho de Melo
2024-11-05 15:50 ` Ian Rogers
2024-11-08 17:50 ` Namhyung Kim
2024-11-09 0:14 ` Namhyung Kim
2024-11-05 14:26 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105142616.761042-5-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=vmolnaro@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.