From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Zhongqiu Han <quic_zhonhan@quicinc.com>,
manivannan.sadhasivam@linaro.org, kishon@kernel.org,
bhelgaas@google.com, lpieralisi@kernel.org, dlemoal@kernel.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: epf-mhi: Fix potential NULL dereference in pci_epf_mhi_bind()
Date: Wed, 6 Nov 2024 01:07:22 +0900 [thread overview]
Message-ID: <20241105160722.GA448500@rocinante> (raw)
In-Reply-To: <ZyofRAZoAE5IgCVi@ryzen>
Hello,
[...]
> > /* Get MMIO base address from Endpoint controller */
> > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mmio");
> > + if (!res) {
> > + dev_err(&pdev->dev, "Failed to get MMIO base address\n");
>
> dev_err(&epf->dev, "Failed to get mmio resource\n");
> or
> dev_err(&epf->dev, "Failed to get \"mmio\" resource\n");
>
> Note: &epf->dev instead of &pdev->dev in order to be consistent with other
> EPF ->bind() functions.
>
> With that, feel free to add:
> Reviewed-by: Niklas Cassel <cassel@kernel.org>
Thank you Niklas!
No need to send a new version of this patch. I will update it on the
branch when applying. Thank you!
Krzysztof
next prev parent reply other threads:[~2024-11-05 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 12:07 [PATCH] PCI: epf-mhi: Fix potential NULL dereference in pci_epf_mhi_bind() Zhongqiu Han
2024-11-05 13:36 ` Niklas Cassel
2024-11-05 16:07 ` Krzysztof Wilczyński [this message]
2024-11-05 17:38 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105160722.GA448500@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=quic_zhonhan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.