All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Nadia Pinaeva <n.m.pinaeva@gmail.com>,
	Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org,
	Antonio Ojea <antonio.ojea.garcia@gmail.com>
Subject: Re: [PATCH nf-next v2] netfilter: conntrack: collect start time as early as possible
Date: Tue, 5 Nov 2024 17:23:46 +0100	[thread overview]
Message-ID: <20241105162346.GA9442@breakpoint.cc> (raw)
In-Reply-To: <ZypDF4Suic4REwM8@calendula>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Nov 03, 2024 at 11:26:36AM +0100, Nadia Pinaeva wrote:
> > I would like to provide some more context from the user point of view.
> > I am working on a tool that allows collecting network performance
> > metrics by using conntrack events.
> > Start time of a conntrack entry is used to evaluate seen_reply
> > latency, therefore the sooner it is timestamped, the better the
> > precision is.
> > In particular, when using this tool to compare the performance of the
> > same feature implemented using iptables/nftables/OVS it is crucial
> > to have the entry timestamped earlier to see any difference.
> > 
> > I am not sure if current timestamping logic is used for anything, but
> > changing it would definitely help with my use case.
> > I am happy to provide more details, if you have any questions.
> 
> The start time will be accurate. However, stop time will not be very
> accurate: the netlink message containing the SEEN_REPLY status flag
> can sit in the socket queue for some quite time until the userspace
> software has a chance to receive and parse it.
> 
> @Florian: Would you explore instead to extend the nf_conntrack_ecache
> infrastructure to allow to provide timestamps for netlink events? This
> can be enabled via toggle. That would allow to have a more accurate
> delta between two events messages.

Simply using current time in ctnetlink won't help, the NEW event comes
after confirm.

It will help for SEEN_REPLY.  But I don't see how it will avoid this
patch.

  reply	other threads:[~2024-11-05 16:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 13:12 [PATCH nf-next v2] netfilter: conntrack: collect start time as early as possible Florian Westphal
2024-11-03 10:26 ` Nadia Pinaeva
2024-11-04  9:09   ` Pablo Neira Ayuso
2024-11-04  9:39     ` Florian Westphal
2024-11-04 10:03       ` Nadia Pinaeva
2024-11-04 11:09         ` Antonio Ojea
2024-11-05 16:08   ` Pablo Neira Ayuso
2024-11-05 16:23     ` Florian Westphal [this message]
2024-11-05 16:28       ` Pablo Neira Ayuso
2024-11-05 16:33         ` Florian Westphal
2024-11-05 16:45           ` Pablo Neira Ayuso
2024-11-05 17:32             ` Florian Westphal
2024-11-05 23:20               ` Pablo Neira Ayuso
2024-11-06  8:26                 ` Florian Westphal
2024-11-06  8:32                   ` Pablo Neira Ayuso
2024-11-06  8:34                     ` Florian Westphal
2024-11-06  9:10                       ` Pablo Neira Ayuso
2024-11-06 12:39                         ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105162346.GA9442@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=antonio.ojea.garcia@gmail.com \
    --cc=n.m.pinaeva@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.