From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <andrew+netdev@lunn.ch>, <daniel@iogearbox.net>,
<davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuni1840@gmail.com>, <mailhol.vincent@wanadoo.fr>,
<mkl@pengutronix.de>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <razor@blackwall.org>
Subject: Re: [PATCH v1 net-next 3/8] rtnetlink: Add peer_type in struct rtnl_link_ops.
Date: Tue, 5 Nov 2024 17:04:47 -0800 [thread overview]
Message-ID: <20241105170447.1d32beda@kernel.org> (raw)
In-Reply-To: <20241106005825.3537-1-kuniyu@amazon.com>
On Tue, 5 Nov 2024 16:58:25 -0800 Kuniyuki Iwashima wrote:
> > > I guess compiler will warn if someone tries to use < 255
> >
> > I chose 1 just because all of the three peer attr types were 1.
>
> s/chose 1/chose u8/ :)
>
>
> > Should peer_type be u16 or extend when a future device use >255 for
> > peer ifla ?
I think we can extend in the future if you're doing this for packing
reasons. Barely any family has more attrs than 256 and as I replied to
myself we will assign a constant so compiler will warn us.
next prev parent reply other threads:[~2024-11-06 1:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 2:05 [PATCH v1 net-next 0/8] rtnetlink: Convert rtnl_newlink() to per-netns RTNL Kuniyuki Iwashima
2024-11-05 2:05 ` [PATCH v1 net-next 1/8] rtnetlink: Introduce struct rtnl_nets and helpers Kuniyuki Iwashima
2024-11-05 10:16 ` Eric Dumazet
2024-11-06 0:35 ` Jakub Kicinski
2024-11-06 0:41 ` Kuniyuki Iwashima
2024-11-05 2:05 ` [PATCH v1 net-next 2/8] rtnetlink: Factorise rtnl_link_get_net_tb() Kuniyuki Iwashima
2024-11-05 10:18 ` Eric Dumazet
2024-11-06 0:37 ` Jakub Kicinski
2024-11-06 0:44 ` Kuniyuki Iwashima
2024-11-05 2:05 ` [PATCH v1 net-next 3/8] rtnetlink: Add peer_type in struct rtnl_link_ops Kuniyuki Iwashima
2024-11-05 10:23 ` Eric Dumazet
2024-11-06 0:39 ` Jakub Kicinski
2024-11-06 0:39 ` Jakub Kicinski
2024-11-06 0:52 ` Kuniyuki Iwashima
2024-11-06 0:58 ` Kuniyuki Iwashima
2024-11-06 1:04 ` Jakub Kicinski [this message]
2024-11-06 1:22 ` Kuniyuki Iwashima
2024-11-05 2:05 ` [PATCH v1 net-next 4/8] veth: Set VETH_INFO_PEER to veth_link_ops.peer_type Kuniyuki Iwashima
2024-11-05 10:24 ` Eric Dumazet
2024-11-05 2:05 ` [PATCH v1 net-next 5/8] vxcan: Set VXCAN_INFO_PEER to vxcan_link_ops.peer_type Kuniyuki Iwashima
2024-11-05 10:37 ` Eric Dumazet
2024-11-05 2:05 ` [PATCH v1 net-next 6/8] netkit: Set IFLA_NETKIT_PEER_INFO to netkit_link_ops.peer_type Kuniyuki Iwashima
2024-11-05 10:39 ` Eric Dumazet
2024-11-05 2:05 ` [PATCH v1 net-next 7/8] rtnetlink: Convert RTM_NEWLINK to per-netns RTNL Kuniyuki Iwashima
2024-11-05 10:40 ` Eric Dumazet
2024-11-05 16:22 ` Paolo Abeni
2024-11-05 17:11 ` Kuniyuki Iwashima
2024-11-05 2:05 ` [PATCH v1 net-next 8/8] rtnetlink: Register rtnl_dellink() and rtnl_setlink() with RTNL_FLAG_DOIT_PERNET_WIP Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105170447.1d32beda@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.