From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: [PATCH net-next 7/7] net: add debug check in skb_reset_mac_header()
Date: Tue, 5 Nov 2024 17:44:03 +0000 [thread overview]
Message-ID: <20241105174403.850330-8-edumazet@google.com> (raw)
In-Reply-To: <20241105174403.850330-1-edumazet@google.com>
Make sure (skb->data - skb->head) can fit in skb->mac_header
This needs CONFIG_DEBUG_NET=y.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
include/linux/skbuff.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index f1e49a32880df8f3716c585d13c1085a2183978a..e5095d75abba18c5c5301ddc39c40cdcf5e528ed 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -3063,7 +3063,10 @@ static inline void skb_unset_mac_header(struct sk_buff *skb)
static inline void skb_reset_mac_header(struct sk_buff *skb)
{
- skb->mac_header = skb->data - skb->head;
+ long offset = skb->data - skb->head;
+
+ DEBUG_NET_WARN_ON_ONCE(offset != (typeof(skb->mac_header))offset);
+ skb->mac_header = offset;
}
static inline void skb_set_mac_header(struct sk_buff *skb, const int offset)
--
2.47.0.199.ga7371fff76-goog
next prev parent reply other threads:[~2024-11-05 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 17:43 [PATCH net-next 0/7] net: add debug checks to skb_reset_xxx_header() Eric Dumazet
2024-11-05 17:43 ` [PATCH net-next 1/7] net: skb_reset_mac_len() must check if mac_header was set Eric Dumazet
2024-11-05 17:56 ` Joe Damato
2024-11-05 17:43 ` [PATCH net-next 2/7] net: add debug check in skb_reset_inner_transport_header() Eric Dumazet
2024-11-05 17:57 ` Joe Damato
2024-11-05 17:43 ` [PATCH net-next 3/7] net: add debug check in skb_reset_inner_network_header() Eric Dumazet
2024-11-05 17:57 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 4/7] net: add debug check in skb_reset_inner_mac_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 5/7] net: add debug check in skb_reset_transport_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 6/7] net: add debug check in skb_reset_network_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` Eric Dumazet [this message]
2024-11-05 17:59 ` [PATCH net-next 7/7] net: add debug check in skb_reset_mac_header() Joe Damato
2024-11-06 9:52 ` [PATCH net-next 0/7] net: add debug checks to skb_reset_xxx_header() Xuan Zhuo
2024-11-07 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105174403.850330-8-edumazet@google.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.