From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 1/3] ebtables: Clone extensions before modifying them
Date: Tue, 5 Nov 2024 23:03:39 +0100 [thread overview]
Message-ID: <20241105220339.GD10152@breakpoint.cc> (raw)
In-Reply-To: <20241105203543.10545-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Upon identifying an extension option, ebt_command_default() would have
> the extension parse the option prior to creating a copy for attaching to
> the iptables_command_state object. After copying, the (modified)
> initial extension's data was cleared.
Patches look good to me, thanks for adding test cases.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2024-11-05 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 20:35 [iptables PATCH 1/3] ebtables: Clone extensions before modifying them Phil Sutter
2024-11-05 20:35 ` [iptables PATCH 2/3] ebtables: Simplify ebt_add_{match,watcher} Phil Sutter
2024-11-05 20:35 ` [iptables PATCH 3/3] tests: shell: Test ebtables-restore deleting among matches Phil Sutter
2024-11-05 22:03 ` Florian Westphal [this message]
2024-11-05 23:03 ` [iptables PATCH 1/3] ebtables: Clone extensions before modifying them Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105220339.GD10152@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.