Re: [PATCH v3] pps: Fix a use-after-free

[kernel test robot <lkp@intel.com>]

Hi Calvin,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.12-rc6 next-20241105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Calvin-Owens/pps-Fix-a-use-after-free/20241105-155819
base:   linus/master
patch link:    https://lore.kernel.org/r/abc43b18f21379c21a4d2c63372a04b2746be665.1730792731.git.calvin%40wbinvd.org
patch subject: [PATCH v3] pps: Fix a use-after-free
config: i386-buildonly-randconfig-004-20241105 (https://download.01.org/0day-ci/archive/20241106/202411060043.hC5KjYAw-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241106/202411060043.hC5KjYAw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411060043.hC5KjYAw-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_complete':
>> drivers/ptp/ptp_ocp.c:4423:40: error: incompatible type for argument 2 of 'ptp_ocp_symlink'
    4423 |                 ptp_ocp_symlink(bp, pps->dev, "pps");
         |                                     ~~~^~~~~
         |                                        |
         |                                        struct device
   drivers/ptp/ptp_ocp.c:4387:52: note: expected 'struct device *' but argument is of type 'struct device'
    4387 | ptp_ocp_symlink(struct ptp_ocp *bp, struct device *child, const char *link)
         |                                     ~~~~~~~~~~~~~~~^~~~~


vim +/ptp_ocp_symlink +4423 drivers/ptp/ptp_ocp.c

773bda96492153 Jonathan Lemon  2021-08-03  4411  
773bda96492153 Jonathan Lemon  2021-08-03  4412  static int
773bda96492153 Jonathan Lemon  2021-08-03  4413  ptp_ocp_complete(struct ptp_ocp *bp)
773bda96492153 Jonathan Lemon  2021-08-03  4414  {
773bda96492153 Jonathan Lemon  2021-08-03  4415  	struct pps_device *pps;
773bda96492153 Jonathan Lemon  2021-08-03  4416  	char buf[32];
d7875b4b078f7e Vadim Fedorenko 2024-08-29  4417  
773bda96492153 Jonathan Lemon  2021-08-03  4418  	sprintf(buf, "ptp%d", ptp_clock_index(bp->ptp));
773bda96492153 Jonathan Lemon  2021-08-03  4419  	ptp_ocp_link_child(bp, buf, "ptp");
773bda96492153 Jonathan Lemon  2021-08-03  4420  
773bda96492153 Jonathan Lemon  2021-08-03  4421  	pps = pps_lookup_dev(bp->ptp);
773bda96492153 Jonathan Lemon  2021-08-03  4422  	if (pps)
773bda96492153 Jonathan Lemon  2021-08-03 @4423  		ptp_ocp_symlink(bp, pps->dev, "pps");
773bda96492153 Jonathan Lemon  2021-08-03  4424  
f67bf662d2cffa Jonathan Lemon  2021-09-14  4425  	ptp_ocp_debugfs_add_device(bp);
f67bf662d2cffa Jonathan Lemon  2021-09-14  4426  
773bda96492153 Jonathan Lemon  2021-08-03  4427  	return 0;
773bda96492153 Jonathan Lemon  2021-08-03  4428  }
773bda96492153 Jonathan Lemon  2021-08-03  4429  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki