From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
netdev@vger.kernel.org, "Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
virtualization@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v2 02/13] virtio_ring: split: record extras for indirect buffers
Date: Wed, 6 Nov 2024 02:42:30 -0500 [thread overview]
Message-ID: <20241106024153-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEt4HfEAyUGe8CL3eLJmbrcz9Uz1rhCo7_j4aShzLa4iEQ@mail.gmail.com>
On Wed, Nov 06, 2024 at 09:44:39AM +0800, Jason Wang wrote:
> > > > while (vq->split.vring.desc[i].flags & nextflag) {
> > > > - vring_unmap_one_split(vq, i);
> > > > + vring_unmap_one_split(vq, &extra[i]);
> > >
> > > Not sure if I've asked this before. But this part seems to deserve an
> > > independent fix for -stable.
> >
> > What fix?
>
> I meant for hardening we need to check the flags stored in the extra
> instead of the descriptor itself as it could be mangled by the device.
>
> Thanks
Good point. Jason, want to cook up a patch?
--
MST
next prev parent reply other threads:[~2024-11-06 7:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:24 [PATCH net-next v2 00/13] virtio-net: support AF_XDP zero copy (tx) Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 01/13] virtio_ring: introduce vring_need_unmap_buffer Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 02/13] virtio_ring: split: record extras for indirect buffers Xuan Zhuo
2024-11-05 3:42 ` Jason Wang
2024-11-05 6:51 ` Xuan Zhuo
2024-11-06 1:44 ` Jason Wang
2024-11-06 5:58 ` Xuan Zhuo
2024-11-06 7:42 ` Michael S. Tsirkin [this message]
2024-11-11 1:27 ` Jason Wang
2024-10-30 8:24 ` [PATCH net-next v2 03/13] virtio_ring: packed: " Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 04/13] virtio_ring: perform premapped operations based on per-buffer Xuan Zhuo
2024-11-05 4:25 ` Jason Wang
2024-10-30 8:24 ` [PATCH net-next v2 05/13] virtio_ring: introduce add api for premapped Xuan Zhuo
2024-10-31 2:19 ` kernel test robot
2024-11-05 4:28 ` Jason Wang
2024-10-30 8:24 ` [PATCH net-next v2 06/13] virtio-net: rq submits premapped per-buffer Xuan Zhuo
2024-11-05 3:23 ` Jason Wang
2024-11-05 7:09 ` Xuan Zhuo
2024-11-06 1:56 ` Jason Wang
2024-11-06 5:55 ` Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 07/13] virtio_ring: remove API virtqueue_set_dma_premapped Xuan Zhuo
2024-11-05 4:29 ` Jason Wang
2024-10-30 8:24 ` [PATCH net-next v2 08/13] virtio_net: refactor the xmit type Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 09/13] virtio_net: xsk: bind/unbind xsk for tx Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 10/13] virtio_net: xsk: prevent disable tx napi Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 11/13] virtio_net: xsk: tx: support xmit xsk buffer Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 12/13] virtio_net: update tx timeout record Xuan Zhuo
2024-10-30 8:24 ` [PATCH net-next v2 13/13] virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106024153-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.