From: "Michael S. Tsirkin" <mst@redhat.com>
To: Philo Lu <lulie@linux.alibaba.com>
Cc: netdev@vger.kernel.org, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, andrew@daynix.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/4] virtio_net: Make RSS interact properly with queue number
Date: Wed, 6 Nov 2024 04:31:24 -0500 [thread overview]
Message-ID: <20241106043106-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20241104085706.13872-1-lulie@linux.alibaba.com>
On Mon, Nov 04, 2024 at 04:57:02PM +0800, Philo Lu wrote:
> With this patch set, RSS updates with queue_pairs changing:
> - When virtnet_probe, init default rss and commit
> - When queue_pairs changes _without_ user rss configuration, update rss
> with the new queue number
> - When queue_pairs changes _with_ user rss configuration, keep rss as user
> configured
>
> Patch 1 and 2 fix possible out of bound errors for indir_table and key.
> Patch 3 and 4 add RSS update in probe() and set_queues().
>
> Please review, thanks.
Looks reasonable.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Philo Lu (4):
> virtio_net: Support dynamic rss indirection table size
> virtio_net: Add hash_key_length check
> virtio_net: Sync rss config to device when virtnet_probe
> virtio_net: Update rss when set queue
>
> drivers/net/virtio_net.c | 119 ++++++++++++++++++++++++++++++++-------
> 1 file changed, 100 insertions(+), 19 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
next prev parent reply other threads:[~2024-11-06 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 8:57 [PATCH net 0/4] virtio_net: Make RSS interact properly with queue number Philo Lu
2024-11-04 8:57 ` [PATCH net 1/4] virtio_net: Support dynamic rss indirection table size Philo Lu
2024-11-05 20:27 ` Joe Damato
2024-11-04 8:57 ` [PATCH net 2/4] virtio_net: Add hash_key_length check Philo Lu
2024-11-05 20:28 ` Joe Damato
2024-11-04 8:57 ` [PATCH net 3/4] virtio_net: Sync rss config to device when virtnet_probe Philo Lu
2024-11-05 20:29 ` Joe Damato
2024-11-04 8:57 ` [PATCH net 4/4] virtio_net: Update rss when set queue Philo Lu
2024-11-05 20:31 ` Joe Damato
2024-11-06 1:28 ` Philo Lu
2024-11-07 11:39 ` Paolo Abeni
2024-11-06 8:58 ` [PATCH net 0/4] virtio_net: Make RSS interact properly with queue number Xuan Zhuo
2024-11-11 1:30 ` Jason Wang
2024-11-06 9:31 ` Michael S. Tsirkin [this message]
2024-11-07 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106043106-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@daynix.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.