From: Lee Jones <lee@kernel.org>
To: pavel@ucw.cz, Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
kernel@salutedevices.com, rockosov@gmail.com,
Alexey Romanov <avromanov@salutedevices.com>
Subject: Re: (subset) [PATCH v2] leds: introduce ordered workqueue for leds events instead of system_wq
Date: Wed, 6 Nov 2024 08:12:39 +0000 [thread overview]
Message-ID: <20241106081239.GF1807686@google.com> (raw)
In-Reply-To: <173088071827.3234293.7159770328606603865.b4-ty@kernel.org>
On Wed, 06 Nov 2024, Lee Jones wrote:
> On Wed, 04 Sep 2024 01:39:30 +0300, Dmitry Rokosov wrote:
> > This allows to setup ordered workqueue for leds events. This may be
> > useful, because default 'system_wq' does not guarantee execution order
> > of each work_struct, thus for several brightness update requests (for
> > multiple leds), real brightness switch could be in random order.
> >
> > Yes, for sysfs-based leds we have flush_work() call inside
> > brightness_store() operation, but it's blocking call, so userspace
> > caller can be blocked at a long time, which means leds animation stream
> > can be broken.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] leds: introduce ordered workqueue for leds events instead of system_wq
> commit: 32360bf6a5d4016669c3545e7b0ec939937f5331
With a couple of style fix-ups.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-11-06 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 22:39 [PATCH v2] leds: introduce ordered workqueue for leds events instead of system_wq Dmitry Rokosov
2024-09-16 11:18 ` Dmitry Rokosov
2024-09-17 8:04 ` Lee Jones
2024-10-22 14:22 ` Dmitry Rokosov
2024-10-29 20:06 ` Dmitry Rokosov
2024-10-31 10:28 ` Lee Jones
2024-11-06 8:11 ` (subset) " Lee Jones
2024-11-06 8:12 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106081239.GF1807686@google.com \
--to=lee@kernel.org \
--cc=avromanov@salutedevices.com \
--cc=ddrokosov@salutedevices.com \
--cc=kernel@salutedevices.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.