From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, hch@lst.de, m@bjorling.me,
matias.bjorling@wdc.com,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 11/11] nvme: add rotational support
Date: Wed, 6 Nov 2024 09:22:32 +0100 [thread overview]
Message-ID: <20241106082232.GA3779@lst.de> (raw)
In-Reply-To: <9614c5af-7418-47b9-833e-388cdf1bdca4@linux.alibaba.com>
On Wed, Nov 06, 2024 at 03:57:06PM +0800, Guixin Liu wrote:
> May I pose a question, what does BLK_FEAT_ADD_RANDOM do?
Nothing.
> I see the scsi call add_disk_randomness() in scsi_end_request() if
> request_queue has
Yes.
>
> BLK_FEAT_ADD_RANDOM flag, but I dont see any calls in the patchset.
I actually pointed that out last round and thought it got fixed,
should have noticed it wasn't this time around. The flag really
should be dropped.
next prev parent reply other threads:[~2024-11-06 8:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 17:48 [PATCHv3 00/11] Rotational storage support Keith Busch
2024-11-05 17:48 ` [PATCHv3 01/11] nvmet: implement id ns for nvm command set Keith Busch
2024-11-06 5:05 ` Chaitanya Kulkarni
2024-11-06 5:38 ` Christoph Hellwig
2024-11-07 0:30 ` Keith Busch
2024-11-05 17:48 ` [PATCHv3 02/11] nvmet: implement active command set ns list Keith Busch
2024-11-06 5:06 ` Chaitanya Kulkarni
2024-11-06 5:38 ` Christoph Hellwig
2024-11-05 17:48 ` [PATCHv3 03/11] nvmet: implement supported log pages Keith Busch
2024-11-06 4:24 ` Kanchan Joshi
2024-11-06 5:16 ` Chaitanya Kulkarni
2024-11-06 5:18 ` Chaitanya Kulkarni
2024-11-06 5:39 ` Christoph Hellwig
2024-11-05 17:48 ` [PATCHv3 04/11] nvmet: implement supported features log Keith Busch
2024-11-06 5:19 ` Chaitanya Kulkarni
2024-11-06 5:43 ` Christoph Hellwig
2024-11-05 17:48 ` [PATCHv3 05/11] nvmet: implement crto property Keith Busch
2024-11-06 5:43 ` Christoph Hellwig
2024-11-05 17:48 ` [PATCHv3 06/11] nvmet: declare 2.1 version compliance Keith Busch
2024-11-06 5:20 ` Chaitanya Kulkarni
2024-11-06 5:45 ` Christoph Hellwig
2024-11-06 6:13 ` Chaitanya Kulkarni
2024-11-05 17:49 ` [PATCHv3 07/11] nvmet: implement endurance groups Keith Busch
2024-11-06 5:23 ` Chaitanya Kulkarni
2024-11-06 5:55 ` Christoph Hellwig
2024-11-05 17:49 ` [PATCHv3 08/11] nvmet: implement rotational media information log Keith Busch
2024-11-06 5:56 ` Christoph Hellwig
2024-11-05 17:49 ` [PATCHv3 09/11] nvmet: support for csi identify ns Keith Busch
2024-11-06 5:46 ` Guixin Liu
2024-11-05 17:49 ` [PATCHv3 10/11] nvme: make independent ns identify default Keith Busch
2024-11-05 20:29 ` Keith Busch
2024-11-06 5:57 ` Christoph Hellwig
2024-11-05 17:49 ` [PATCHv3 11/11] nvme: add rotational support Keith Busch
2024-11-06 5:58 ` Christoph Hellwig
2024-11-06 6:15 ` Chaitanya Kulkarni
2024-11-06 7:57 ` Guixin Liu
2024-11-06 8:22 ` Christoph Hellwig [this message]
2024-11-07 0:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106082232.GA3779@lst.de \
--to=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.