All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Srujana Challa <schalla@marvell.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"eperezma@redhat.com" <eperezma@redhat.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode
Date: Wed, 6 Nov 2024 13:11:41 -0500	[thread overview]
Message-ID: <20241106131108-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DS0PR18MB5368B1BCC3CFAE5D7E4EB627A0532@DS0PR18MB5368.namprd18.prod.outlook.com>

On Wed, Nov 06, 2024 at 12:38:02PM +0000, Srujana Challa wrote:
> > Subject: Re: [EXTERNAL] Re: [PATCH v2 0/2] vhost-vdpa: Add support for NO-
> > IOMMU mode
> > 
> > On Wed, Oct 23, 2024 at 04: 19: 02AM -0400, Michael S. Tsirkin wrote: > On
> > Tue, Oct 22, 2024 at 11: 58: 19PM -0700, Christoph Hellwig wrote: > > On Sat,
> > Oct 19, 2024 at 08: 16: 44PM -0400, Michael S. Tsirkin wrote: > > > Because
> > 
> > On Wed, Oct 23, 2024 at 04:19:02AM -0400, Michael S. Tsirkin wrote:
> > > On Tue, Oct 22, 2024 at 11:58:19PM -0700, Christoph Hellwig wrote:
> > > > On Sat, Oct 19, 2024 at 08:16:44PM -0400, Michael S. Tsirkin wrote:
> > > > > Because people want to move from some vendor specific solution
> > > > > with vfio to a standard vdpa compatible one with vdpa.
> > > >
> > > > So now you have a want for new use cases and you turn that into a
> > > > must for supporting completely insecure and dangerous crap.
> > >
> > > Nope.
> > >
> > > kernel is tainted -> unsupported
> > >
> > > whoever supports tainted kernels is already in dangerous waters.
> > 
> > That's not a carte blanche for doing whatever crazy stuff you want.
> > 
> > And if you don't trust me I'll add Greg who has a very clear opinion on
> > IOMMU-bypassing user I/O hooks in the style of the uio driver as well I think
> > :)
> 
> It is going in circles, let me give the summary,
> Issue: We need to address the lack of no-IOMMU support in the vhost vDPA driver for better performance.
> Measured Performance: On the machine "13th Gen Intel(R) Core(TM) i9-13900K, 32 Cores", we observed
> a performance improvement of 70 - 80% with intel_iommu=off when we run high-throughput network
> packet processing.
> Rationale for Fix: High-end machines which gives better performance with IOMMU are very expensive,
> and certain use cases, such as embedded environment and trusted applications, do not require
> the security features provided by IOMMU.
> Initial Approach: We initially considered a driver-based solution, specifically integrating no-IOMMU
> support into Marvell’s octep-vdpa driver.
> Initial Community Feedback: The community suggested adopting a VFIO-like scheme to make the solution
> more generic and widely applicable.
> Decision Point: Should we pursue a generic approach for no-IOMMU support in the vhost vDPA driver,
> or should we implement a driver-specific solution?
> 
> Thanks,
> Srujana.

This point does not matter for Christoph.

-- 
MST


  parent reply	other threads:[~2024-11-06 18:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 14:05 [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode Srujana Challa
2024-09-20 14:05 ` [PATCH v2 1/2] vhost-vdpa: introduce module parameter for no-IOMMU mode Srujana Challa
2024-09-21 17:28   ` kernel test robot
2024-09-20 14:05 ` [PATCH v2 2/2] vhost-vdpa: introduce NO-IOMMU backend feature bit Srujana Challa
2024-09-24  7:43   ` Jason Wang
2024-09-24 10:01     ` [EXTERNAL] " Srujana Challa
2024-10-01  8:47 ` [PATCH v2 0/2] vhost-vdpa: Add support for NO-IOMMU mode Christoph Hellwig
2024-10-14 13:18   ` [EXTERNAL] " Srujana Challa
2024-10-15  3:48     ` Christoph Hellwig
2024-10-16 17:28       ` Srujana Challa
2024-10-17  6:19         ` Christoph Hellwig
2024-10-17  8:53           ` Srujana Challa
2024-10-18  4:54             ` Jason Wang
2024-10-18  5:24             ` Christoph Hellwig
2024-10-18 13:08               ` Srujana Challa
2024-10-16 17:41       ` Michael S. Tsirkin
2024-10-17  6:16         ` Christoph Hellwig
2024-10-20  0:16           ` Michael S. Tsirkin
2024-10-23  6:58             ` Christoph Hellwig
2024-10-23  8:19               ` Michael S. Tsirkin
2024-10-24  9:05                 ` Christoph Hellwig
2024-11-06 12:38                   ` Srujana Challa
2024-11-06 15:45                     ` Christoph Hellwig
2024-11-07  6:08                       ` Srujana Challa
2024-11-12  7:11                         ` Srujana Challa
2024-11-06 18:11                     ` Michael S. Tsirkin [this message]
2024-11-06 18:14                   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241106131108-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=jasowang@redhat.com \
    --cc=jerinj@marvell.com \
    --cc=kvm@vger.kernel.org \
    --cc=ndabilpuram@marvell.com \
    --cc=schalla@marvell.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.