From: mhkelley58@gmail.com
To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, gregkh@linuxfoundation.org,
vkuznets@redhat.com
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] Drivers: hv: util: Two fixes in util_probe()
Date: Wed, 6 Nov 2024 07:42:45 -0800 [thread overview]
Message-ID: <20241106154247.2271-1-mhklinux@outlook.com> (raw)
From: Michael Kelley <mhklinux@outlook.com>
Patch 1 fixes util_probe() to not force the error return value to
ENODEV when the util_init function fails -- just return the error
code from util_init so the real error code is displayed in messages.
Patch 2 fixes a more serious race condition between initialization
of the VMBus channel and initial operations of the user space
daemons for KVP and VSS. The fix reorders the initialization in
util_probe() so the race condition can't happen.
The two fixes are functionally independent, but Patch 2 introduces
the util_init_transport function that parallels the existing code
for the util_init function. Doing Patch 1 first avoids an
inconsistency in the error handling in similar code for these two
parts of util_probe().
This series is v2 of a single patch first posted by Dexuan Cui
to fix the race condition.[1] I've taken over the patch per
discussion with Dexuan.
[1] https://lore.kernel.org/linux-hyperv/20240909164719.41000-1-decui@microsoft.com/
Michael Kelley (2):
Drivers: hv: util: Don't force error code to ENODEV in util_probe()
Drivers: hv: util: Avoid accessing a ringbuffer not initialized yet
drivers/hv/hv_kvp.c | 6 ++++++
drivers/hv/hv_snapshot.c | 6 ++++++
drivers/hv/hv_util.c | 13 ++++++++++---
drivers/hv/hyperv_vmbus.h | 2 ++
include/linux/hyperv.h | 1 +
5 files changed, 25 insertions(+), 3 deletions(-)
--
2.25.1
next reply other threads:[~2024-11-06 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 15:42 mhkelley58 [this message]
2024-11-06 15:42 ` [PATCH v2 1/2] Drivers: hv: util: Don't force error code to ENODEV in util_probe() mhkelley58
2024-12-08 17:30 ` Saurabh Singh Sengar
2024-12-08 23:12 ` Michael Kelley
2024-12-09 17:30 ` Saurabh Singh Sengar
2024-11-06 15:42 ` [PATCH v2 2/2] Drivers: hv: util: Avoid accessing a ringbuffer not initialized yet mhkelley58
2024-12-06 2:44 ` [PATCH v2 0/2] Drivers: hv: util: Two fixes in util_probe() Michael Kelley
2024-12-07 7:02 ` Wei Liu
2024-12-07 7:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106154247.2271-1-mhklinux@outlook.com \
--to=mhkelley58@gmail.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.