Re: [Buildroot] [PATCH v4 2/6] package/grpc: bump to version 1.66.1

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Kamel Bouhara <kamel.bouhara@gmail.com>,
	Woodrow Douglass <wdouglass@carnegierobotics.com>,
	Julien Olivain <ju.o@free.fr>, Asaf Kahlon <asafka7@gmail.com>,
	Marcin Niestroj <m.niestroj@grinn-global.com>,
	Christian Stewart <christian@aperture.us>,
	Robert Rose <robertroyrose@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 2/6] package/grpc: bump to version 1.66.1
Date: Wed, 6 Nov 2024 22:30:15 +0100	[thread overview]
Message-ID: <20241106223015.75d7b3b4@windsurf> (raw)
In-Reply-To: <20241030190020.1444105-2-james.hilliard1@gmail.com>

On Wed, 30 Oct 2024 13:00:16 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Add new -DgRPC_BUILD_CODEGEN=OFF config option which is required if
> no plugins are enabled.
> 
> Drop no longer relevant add GPR_DISABLE_WRAPPED_MEMCPY patch.
> 
> Rebase remaining patches.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

There's something I'm not super happy with with this bump:

- It is needed to fix the current build breakage in grpc
  (http://autobuild.buildroot.net/results/b2dfc13dcac8396bc7510a4d992558a01d3c9f22/),
  which is caused by your bump of libabseil-cpp in
  0d40b47866753340b214e811af53e6a95216bbb3.

- But this grpc version bump *requires* the protobuf bump (apparently).
  So it's a lot of version bumps needed to fix a build issue.

I would have preferred a more minimal fix of the grpc build for the
current master, and separately a bump, but backporting the fix for the
libaseil-cpp issue seems difficult.

So, fair enough, let's do it with a protobuf bump + grpc bump.

Overall, I did not apply this patch because it requires your protobuf
bump, but the protobuf bump needs more work.

However, please add into your patch series the following additional
patch:

commit 122e581244877ce4383448a1a298dd9ae480cde7
Author: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date:   Mon Nov 4 23:27:44 2024 +0100

    package/grpc: remove BR2_TOOLCHAIN_HAS_GCC_BUG_85180 dead code
    
    This work-around was added in commit
    716f8b34c526c702aa19e9a66a25df5d3a6ea663 ("package/grpc: work around
    gcc bug 85180") to work around a bug on Microblaze. However, since
    commit
    ae0557403a3a4cbf5354f0ab1784a08623382e5e ("package/libabseil-cpp: add
    BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS"), grpc depends on
    libaseil-cpp, which isn't available on Microblaze, making the
    GCC_BUG_85180 no longer needed, and effectively dead code. This commit
    drops it.
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk
index 47ebf1997c..39be4f583f 100644
--- a/package/grpc/grpc.mk
+++ b/package/grpc/grpc.mk
@@ -59,11 +59,6 @@ GRPC_CFLAGS += -DGPR_DISABLE_WRAPPED_MEMCPY
 GRPC_CXXFLAGS += -DGPR_DISABLE_WRAPPED_MEMCPY
 endif
 
-ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
-GRPC_CFLAGS += -O0
-GRPC_CXXFLAGS += -O0
-endif
-
 GRPC_CONF_OPTS += \
 	-DCMAKE_C_FLAGS="$(GRPC_CFLAGS)" \
 	-DCMAKE_CXX_FLAGS="$(GRPC_CXXFLAGS)"



-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
