From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: check at least one ns identification reported
Date: Thu, 7 Nov 2024 06:28:36 +0100 [thread overview]
Message-ID: <20241107052836.GA1947@lst.de> (raw)
In-Reply-To: <dd51a183-6313-454e-afeb-c00f0cb02f30@linux.alibaba.com>
On Wed, Nov 06, 2024 at 06:47:43PM +0800, Guixin Liu wrote:
> I assume that the dm-multipath
dm-multipath is not supported with nvme..
> will not recognize nvme device if nothing to
> return,
But more importantly the user of the sysfs files is the right place
the just check for these values being non-present. As said before
it's perfectly valid for 1.0 devices so they have to cope with it
anyway. I don't think a message in the kernel log that is very to
process algorithmically is not very useful.
(I really with we'd have useful and required identifiers from the
start, but that's a separate discussion)
next prev parent reply other threads:[~2024-11-07 5:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 3:14 [PATCH v2] nvme: check at least one ns identification reported Guixin Liu
2024-11-04 13:15 ` Christoph Hellwig
2024-11-06 10:47 ` Guixin Liu
2024-11-07 5:28 ` Christoph Hellwig [this message]
2024-11-07 6:18 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107052836.GA1947@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.