From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/1] design: document the changes required to handle metadata directories
Date: Thu, 7 Nov 2024 08:29:53 +0100 [thread overview]
Message-ID: <20241107072953.GD4408@lst.de> (raw)
In-Reply-To: <173092059344.2883162.8918515986395693634.stgit@frogsfrogsfrogs>
On Wed, Nov 06, 2024 at 11:18:38AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Document the ondisk format changes for metadata directories.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> .../allocation_groups.asciidoc | 14 +-
> .../internal_inodes.asciidoc | 113 ++++++++++++++++++++
> .../XFS_Filesystem_Structure/ondisk_inode.asciidoc | 22 ++++
> 3 files changed, 142 insertions(+), 7 deletions(-)
>
>
> diff --git a/design/XFS_Filesystem_Structure/allocation_groups.asciidoc b/design/XFS_Filesystem_Structure/allocation_groups.asciidoc
> index d7fd63ea20a646..ec59519dc2ffc1 100644
> --- a/design/XFS_Filesystem_Structure/allocation_groups.asciidoc
> +++ b/design/XFS_Filesystem_Structure/allocation_groups.asciidoc
> @@ -105,7 +105,7 @@ struct xfs_sb
> xfs_ino_t sb_pquotino;
> xfs_lsn_t sb_lsn;
> uuid_t sb_meta_uuid;
> - xfs_ino_t sb_rrmapino;
> + xfs_ino_t sb_metadirino;
> };
Not new here, but I find it a bit odd that the super block is documented
in allocation_groups.asciidoc.
The change itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-11-07 7:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 19:16 [PATCHBOMB 6.13 v5.5] xfs-docs: metadata directories and realtime groups Darrick J. Wong
2024-11-06 19:17 ` [PATCHSET v31.5 1/3] xfs-documentation: last few updates for online fsck Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/2] design: update metadata reconstruction chapter Darrick J. Wong
2024-11-07 7:28 ` Christoph Hellwig
2024-11-06 19:18 ` [PATCH 2/2] design: document filesystem properties Darrick J. Wong
2024-11-07 7:28 ` Christoph Hellwig
2024-11-06 19:17 ` [PATCHSET v5.5 2/3] xfs-documentation: document metadata directories Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/1] design: document the changes required to handle " Darrick J. Wong
2024-11-07 7:29 ` Christoph Hellwig [this message]
2024-11-07 15:56 ` Darrick J. Wong
2024-11-06 19:17 ` [PATCHSET v5.5 3/3] xfs-documentation: shard the realtime section Darrick J. Wong
2024-11-06 19:18 ` [PATCH 1/4] design: move discussion of realtime volumes to a separate section Darrick J. Wong
2024-11-07 7:30 ` Christoph Hellwig
2024-11-06 19:19 ` [PATCH 2/4] design: document realtime groups Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig
2024-11-07 15:58 ` Darrick J. Wong
2024-11-06 19:19 ` [PATCH 3/4] design: document metadata directory tree quota changes Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig
2024-11-06 19:19 ` [PATCH 4/4] design: update metadump v2 format to reflect rt dumps Darrick J. Wong
2024-11-07 7:33 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-12-31 20:03 [PATCHSET v2.0 1/4] xfs-documentation: document metadata directories Darrick J. Wong
2023-12-27 14:08 ` [PATCH 1/1] design: document the changes required to handle " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107072953.GD4408@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.