From: kernel test robot <lkp@intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
matthew.d.roper@intel.com, jani.nikula@intel.com,
Suraj Kandpal <suraj.kandpal@intel.com>
Subject: Re: [PATCH] drm/i915/hdcp: Handle HDCP Line Rekeying for HDCP 1.4
Date: Thu, 7 Nov 2024 09:54:24 +0800 [thread overview]
Message-ID: <202411070920.hut0uhH0-lkp@intel.com> (raw)
In-Reply-To: <20241106174041.860223-1-suraj.kandpal@intel.com>
Hi Suraj,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20241106]
[cannot apply to linus/master drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-hdcp-Handle-HDCP-Line-Rekeying-for-HDCP-1-4/20241107-015848
base: git://anongit.freedesktop.org/drm-intel for-linux-next
patch link: https://lore.kernel.org/r/20241106174041.860223-1-suraj.kandpal%40intel.com
patch subject: [PATCH] drm/i915/hdcp: Handle HDCP Line Rekeying for HDCP 1.4
config: i386-defconfig (https://download.01.org/0day-ci/archive/20241107/202411070920.hut0uhH0-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241107/202411070920.hut0uhH0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411070920.hut0uhH0-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_hdcp.c:12:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:21:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: warning: variable 'rekey_bit' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:211:2: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
212 | IS_DISPLAY_STEP((__i915), (from), (until)))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:59:35: note: uninitialized use occurs here
59 | intel_de_rmw(display, rekey_reg, rekey_bit, enable ? 0 : rekey_bit);
| ^~~~~~~~~
drivers/gpu/drm/i915/display/intel_de.h:109:67: note: expanded from macro 'intel_de_rmw'
109 | #define intel_de_rmw(p,...) __intel_de_rmw(__to_intel_display(p), __VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:9: note: remove the 'if' if its condition is always true
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: warning: variable 'rekey_bit' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:211:3: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:190:49: note: expanded from macro 'IS_DISPLAY_VERx100'
190 | #define IS_DISPLAY_VERx100(__i915, from, until) ( \
| ^~~
191 | BUILD_BUG_ON_ZERO((from) < 200) + \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
192 | (DISPLAY_VERx100(__i915) >= (from) && \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
193 | DISPLAY_VERx100(__i915) <= (until)))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:59:35: note: uninitialized use occurs here
59 | intel_de_rmw(display, rekey_reg, rekey_bit, enable ? 0 : rekey_bit);
| ^~~~~~~~~
drivers/gpu/drm/i915/display/intel_de.h:109:67: note: expanded from macro 'intel_de_rmw'
109 | #define intel_de_rmw(p,...) __intel_de_rmw(__to_intel_display(p), __VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: note: remove the '&&' if its condition is always true
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^
drivers/gpu/drm/i915/display/intel_display_device.h:211:3: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^
drivers/gpu/drm/i915/display/intel_display_device.h:190:49: note: expanded from macro 'IS_DISPLAY_VERx100'
190 | #define IS_DISPLAY_VERx100(__i915, from, until) ( \
| ^
drivers/gpu/drm/i915/display/intel_hdcp.c:41:15: note: initialize the variable 'rekey_bit' to silence this warning
41 | u32 rekey_bit;
| ^
| = 0
>> drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: warning: variable 'rekey_reg' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:211:2: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
212 | IS_DISPLAY_STEP((__i915), (from), (until)))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:59:24: note: uninitialized use occurs here
59 | intel_de_rmw(display, rekey_reg, rekey_bit, enable ? 0 : rekey_bit);
| ^~~~~~~~~
drivers/gpu/drm/i915/display/intel_de.h:109:67: note: expanded from macro 'intel_de_rmw'
109 | #define intel_de_rmw(p,...) __intel_de_rmw(__to_intel_display(p), __VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:9: note: remove the 'if' if its condition is always true
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: warning: variable 'rekey_reg' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:211:3: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_device.h:190:49: note: expanded from macro 'IS_DISPLAY_VERx100'
190 | #define IS_DISPLAY_VERx100(__i915, from, until) ( \
| ^~~
191 | BUILD_BUG_ON_ZERO((from) < 200) + \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
192 | (DISPLAY_VERx100(__i915) >= (from) && \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
193 | DISPLAY_VERx100(__i915) <= (until)))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:59:24: note: uninitialized use occurs here
59 | intel_de_rmw(display, rekey_reg, rekey_bit, enable ? 0 : rekey_bit);
| ^~~~~~~~~
drivers/gpu/drm/i915/display/intel_de.h:109:67: note: expanded from macro 'intel_de_rmw'
109 | #define intel_de_rmw(p,...) __intel_de_rmw(__to_intel_display(p), __VA_ARGS__)
| ^~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_hdcp.c:54:13: note: remove the '&&' if its condition is always true
54 | } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
| ^
drivers/gpu/drm/i915/display/intel_display_device.h:211:3: note: expanded from macro 'IS_DISPLAY_VERx100_STEP'
211 | (IS_DISPLAY_VERx100((__i915), (ipver), (ipver)) && \
| ^
drivers/gpu/drm/i915/display/intel_display_device.h:190:49: note: expanded from macro 'IS_DISPLAY_VERx100'
190 | #define IS_DISPLAY_VERx100(__i915, from, until) ( \
| ^
drivers/gpu/drm/i915/display/intel_hdcp.c:40:2: note: variable 'rekey_reg' is declared here
40 | i915_reg_t rekey_reg;
| ^
5 warnings generated.
vim +54 drivers/gpu/drm/i915/display/intel_hdcp.c
33
34 static void
35 intel_hdcp_adjust_hdcp_line_rekeying(struct intel_encoder *encoder,
36 struct intel_hdcp *hdcp,
37 bool enable)
38 {
39 struct intel_display *display = to_intel_display(encoder);
40 i915_reg_t rekey_reg;
41 u32 rekey_bit;
42
43 /* Here we assume HDMI is in TMDS mode of operation */
44 if (encoder->type != INTEL_OUTPUT_HDMI)
45 return;
46
47 if (DISPLAY_VER(display) >= 30) {
48 rekey_reg = TRANS_DDI_FUNC_CTL(display, hdcp->cpu_transcoder);
49 rekey_bit = XE3_TRANS_DDI_HDCP_LINE_REKEY_DISABLE;
50 } else if (IS_DISPLAY_VERx100_STEP(display, 1401, STEP_B0, STEP_FOREVER) ||
51 IS_DISPLAY_VERx100_STEP(display, 2000, STEP_B0, STEP_FOREVER)) {
52 rekey_reg = TRANS_DDI_FUNC_CTL(display, hdcp->cpu_transcoder);
53 rekey_bit = TRANS_DDI_HDCP_LINE_REKEY_DISABLE;
> 54 } else if (IS_DISPLAY_VERx100_STEP(display, 1400, STEP_D0, STEP_FOREVER)) {
55 rekey_reg = MTL_CHICKEN_TRANS(hdcp->cpu_transcoder);
56 rekey_bit = HDCP_LINE_REKEY_DISABLE;
57 }
58
59 intel_de_rmw(display, rekey_reg, rekey_bit, enable ? 0 : rekey_bit);
60 }
61
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-07 1:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 17:40 [PATCH] drm/i915/hdcp: Handle HDCP Line Rekeying for HDCP 1.4 Suraj Kandpal
2024-11-06 17:46 ` ✓ CI.Patch_applied: success for drm/i915/hdcp: Handle HDCP Line Rekeying for HDCP 1.4 (rev3) Patchwork
2024-11-06 17:46 ` ✓ CI.checkpatch: " Patchwork
2024-11-06 17:48 ` ✓ CI.KUnit: " Patchwork
2024-11-06 17:59 ` ✓ CI.Build: " Patchwork
2024-11-06 18:01 ` ✓ CI.Hooks: " Patchwork
2024-11-06 18:03 ` ✗ CI.checksparse: warning " Patchwork
2024-11-06 18:27 ` ✓ CI.BAT: success " Patchwork
2024-11-06 18:49 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-07 1:54 ` kernel test robot [this message]
2024-11-08 0:02 ` ✗ CI.FULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-11-07 2:28 [PATCH] drm/i915/hdcp: Handle HDCP Line Rekeying for HDCP 1.4 Suraj Kandpal
2024-11-07 21:44 ` Matt Roper
2024-11-06 12:51 Suraj Kandpal
2024-11-06 16:29 ` Jani Nikula
2024-11-06 16:53 ` Kandpal, Suraj
2024-11-06 9:38 Suraj Kandpal
2024-11-06 10:03 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411070920.hut0uhH0-lkp@intel.com \
--to=lkp@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=llvm@lists.linux.dev \
--cc=matthew.d.roper@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.