Re: [PATCH mdadm/master v2 4/4] mdadm: add support for new lockless bitmap

[Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>]

On Thu,  7 Nov 2024 16:13:47 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> +	if (strcmp(val, "lockless") == 0) {
> +		s->btype = BitmapLockless;
> +		pr_info("Experimental lockless bitmap, use at your own
> disk!\n");
> +		return MDADM_STATUS_SUCCESS;
> +	}
> +

Hi Kuai,
I'm fine with previous patches. For this one, I'm not sure If I can take it yet.
The changes you added if for are not merged, therefore merging this looks bad
from process point of view (I'm merging feature that is not available in
kernel upstream). Am I missing something?

I would like to hear Song voice on that.

IMO, you should keep it as your own customization until development of new
bitmap is done but I understand that the topic is not simple and you might want
to people to test it so having mdadm build-in is an option.

If you really want this I would need a detailed process of "way to stable" in commit
message that I can always refer to. I'm challenging something like that first
time so I hope Song can add something.

Thanks,
Mariusz