From: Jakub Kicinski <kuba@kernel.org>
To: Sanman Pradhan <sanman.p211993@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
kernel-team@meta.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
mohsin.bashr@gmail.com, sanmanpradhan@meta.com,
andrew+netdev@lunn.ch, vadim.fedorenko@linux.dev,
jdamato@fastly.com, sdf@fomichev.me, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics
Date: Thu, 7 Nov 2024 10:20:44 -0800 [thread overview]
Message-ID: <20241107102044.4e5ba38f@kernel.org> (raw)
In-Reply-To: <20241107020555.321245-1-sanman.p211993@gmail.com>
On Wed, 6 Nov 2024 18:05:55 -0800 Sanman Pradhan wrote:
> + FBNIC_HW_STAT("pcie_ob_rd_tlp", pcie.ob_rd_tlp),
> + FBNIC_HW_STAT("pcie_ob_rd_dword", pcie.ob_rd_dword),
> + FBNIC_HW_STAT("pcie_ob_wr_tlp", pcie.ob_wr_tlp),
> + FBNIC_HW_STAT("pcie_ob_wr_dword", pcie.ob_wr_dword),
> + FBNIC_HW_STAT("pcie_ob_cpl_tlp", pcie.ob_cpl_tlp),
> + FBNIC_HW_STAT("pcie_ob_cpl_dword", pcie.ob_cpl_dword),
> + FBNIC_HW_STAT("pcie_ob_rd_no_tag", pcie.ob_rd_no_tag),
> + FBNIC_HW_STAT("pcie_ob_rd_no_cpl_cred", pcie.ob_rd_no_cpl_cred),
> + FBNIC_HW_STAT("pcie_ob_rd_no_np_cred", pcie.ob_rd_no_np_cred),
Having thought about this a bit longer I think Andrew's point is valid.
Let's move these to a debugfs file. Sorry for the flip flop.
next prev parent reply other threads:[~2024-11-07 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 2:05 [PATCH net-next v2] eth: fbnic: Add PCIe hardware statistics Sanman Pradhan
2024-11-07 11:23 ` Leon Romanovsky
2024-11-07 18:20 ` Jakub Kicinski [this message]
2024-11-08 22:37 ` Sanman Pradhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107102044.4e5ba38f@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.