All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jan Beulich" <JBeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 1/3] x86/ucode: Don't use microcode_update_cpu() in early_microcode_load()
Date: Thu,  7 Nov 2024 12:21:15 +0000	[thread overview]
Message-ID: <20241107122117.4073266-2-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <20241107122117.4073266-1-andrew.cooper3@citrix.com>

There are two callers of microcode_update_cpu(), and because one passes NULL
and one doesn't, there are effectively two disjoint pieces of logic wrapped in
a single function.

early_microcode_load()'s use skips all the microcode_cache handling, and is
just a simple patch application.

This skips a redundant collect_cpu_info() call (performed in
early_microcode_init(), marginally earlier), and avoids holding
microcode_mutex when we're not interacting with microcode_cache at all.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/microcode/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c
index 11cd878d1f2e..d9406ec3fd34 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -900,7 +900,7 @@ static int __init early_microcode_load(struct boot_info *bi)
      */
     early_mod_idx = idx;
 
-    rc = microcode_update_cpu(patch, 0);
+    rc = ucode_ops.apply_microcode(patch, 0);
 
  unmap:
     bootstrap_unmap();
-- 
2.39.5



  reply	other threads:[~2024-11-07 12:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 12:21 [PATCH 0/3] x86/ucode: Simplify/fix loading paths further Andrew Cooper
2024-11-07 12:21 ` Andrew Cooper [this message]
2024-11-12 10:34   ` [PATCH 1/3] x86/ucode: Don't use microcode_update_cpu() in early_microcode_load() Jan Beulich
2024-11-07 12:21 ` [PATCH 2/3] x86/ucode: Fold microcode_update_cpu() and fix error handling Andrew Cooper
2024-11-12 10:45   ` Jan Beulich
2024-11-12 12:55     ` Andrew Cooper
2024-11-12 14:24       ` Jan Beulich
2024-11-07 12:21 ` [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob() Andrew Cooper
2024-11-07 21:58   ` Andrew Cooper
2024-11-12 10:36     ` Andrew Cooper
2024-11-12 10:49       ` Jan Beulich
2024-11-12 10:57         ` Andrew Cooper
2024-11-12 11:00           ` Jan Beulich
2024-11-08 12:12 ` [PATCH 4/3] x86/ucode: Fix cache handling in microcode_update_helper() Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107122117.4073266-2-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.