All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: "Michael S . Tsirkin" <mst@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org
Cc: <linuxarm@huawei.com>
Subject: [PATCH 0/5] hw/acpi: Fixes + tests for ACPI Generic Port Affinity Struturs
Date: Thu, 7 Nov 2024 12:34:41 +0000	[thread overview]
Message-ID: <20241107123446.902801-1-Jonathan.Cameron@huawei.com> (raw)

A couple of issues have been reported on this code that has been merged
for 9.2.

A) Missed a version number update in the qapi/qom.json docs when rebasing
   for 9.2.
B) A test failure on i686 (32bit) bios tables test for x86_64.

This second one was a refactoring mistake where visibility of the size
of an array of 8 characters had been replaced with a pointer which on 64
bit hosts is also 8 bytes, but not on 32 bits, leading to a miss-alignment
of the final structure in the table and a test failure. Fix by hard coding
the size as 8 given it is always this size for the relevant ACPI HIDs.

For completeness the tests are also included. Some reference tables
needed an update to incorporate other changes.

Jonathan Cameron (5):
  hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle()
  qapi/qom: Change Since entry for AcpiGenericPortProperties to 9.2
  bios-tables-test: Allow for new acpihmat-generic-x test data.
  bios-tables-test: Add complex SRAT / HMAT test for GI GP
  bios-tables-test: Add data for complex numa test (GI, GP etc)

 qapi/qom.json                                 |   2 +-
 hw/acpi/aml-build.c                           |   2 +-
 tests/qtest/bios-tables-test.c                |  97 ++++++++++++++++++
 .../data/acpi/x86/q35/APIC.acpihmat-generic-x | Bin 0 -> 136 bytes
 .../data/acpi/x86/q35/CEDT.acpihmat-generic-x | Bin 0 -> 68 bytes
 .../data/acpi/x86/q35/DSDT.acpihmat-generic-x | Bin 0 -> 12599 bytes
 .../data/acpi/x86/q35/HMAT.acpihmat-generic-x | Bin 0 -> 360 bytes
 .../data/acpi/x86/q35/SRAT.acpihmat-generic-x | Bin 0 -> 520 bytes
 8 files changed, 99 insertions(+), 2 deletions(-)
 create mode 100644 tests/data/acpi/x86/q35/APIC.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/CEDT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/HMAT.acpihmat-generic-x
 create mode 100644 tests/data/acpi/x86/q35/SRAT.acpihmat-generic-x

-- 
2.43.0



             reply	other threads:[~2024-11-07 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 12:34 Jonathan Cameron via [this message]
2024-11-07 12:34 ` [PATCH 1/5] hw/acpi: Fix size of HID in build_append_srat_acpi_device_handle() Jonathan Cameron via
2024-11-07 12:37   ` Daniel P. Berrangé
2024-11-07 12:34 ` [PATCH 2/5] qapi/qom: Change Since entry for AcpiGenericPortProperties to 9.2 Jonathan Cameron via
2024-11-07 12:36   ` Daniel P. Berrangé
2024-11-07 12:34 ` [PATCH 3/5] bios-tables-test: Allow for new acpihmat-generic-x test data Jonathan Cameron via
2024-11-07 12:34 ` [PATCH 4/5] bios-tables-test: Add complex SRAT / HMAT test for GI GP Jonathan Cameron via
2024-11-07 12:34 ` [PATCH 5/5] bios-tables-test: Add data for complex numa test (GI, GP etc) Jonathan Cameron via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107123446.902801-1-Jonathan.Cameron@huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=berrange@redhat.com \
    --cc=linuxarm@huawei.com \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.