From: Jakub Kicinski <kuba@kernel.org>
To: "Greenwalt, Paul" <paul.greenwalt@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Alice Michael <alice.michael@intel.com>,
Eric Joyner <eric.joyner@intel.com>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support
Date: Thu, 7 Nov 2024 20:14:27 -0800 [thread overview]
Message-ID: <20241107201427.28e00918@kernel.org> (raw)
In-Reply-To: <7aad3452-a08c-4c28-9bd9-3fa1cd1f9b39@intel.com>
On Thu, 7 Nov 2024 17:37:41 -0800 Greenwalt, Paul wrote:
> > why dropping what the user requested with a warning and not just return
> > an error from ice_set_features()?
>
> I took this approach of reducing the feature set to resolve the device
> NETIF_F_HW_CSUM and NETIF_F_ALL_TSO feature limitation, which seemed
> consistent with the guidance in the netdev-features documentation.
My understanding of that guidance is that it is for "positive"
dependencies. Feature A requires feature B, so if feature B is
cleared so should the feature A. Here we have a feature conflict.
next prev parent reply other threads:[~2024-11-08 4:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 22:23 [PATCH net-next 00/15][pull request] Intel Wired LAN Driver Updates 2024-11-05 (ice, ixgbe, igc. igb, igbvf, e1000) Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 01/15] ice: Add E830 checksum offload support Tony Nguyen
2024-11-07 2:08 ` Jakub Kicinski
2024-11-08 1:37 ` Greenwalt, Paul
2024-11-08 4:14 ` Jakub Kicinski [this message]
2024-11-08 23:53 ` Greenwalt, Paul
2024-12-03 19:17 ` Greenwalt, Paul
2024-11-05 22:23 ` [PATCH net-next 02/15] ice: rework of dump serdes equalizer values feature Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 03/15] ice: extend " Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 04/15] ice: refactor "last" segment of DDP pkg Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 05/15] ice: support optional flags in signature segment header Tony Nguyen
2024-11-07 2:11 ` Jakub Kicinski
2024-11-05 22:23 ` [PATCH net-next 06/15] ice: Add support for persistent NAPI config Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 07/15] ice: only allow Tx promiscuous for multicast Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 08/15] ice: initialize pf->supported_rxdids immediately after loading DDP Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 09/15] ice: use stack variable for virtchnl_supported_rxdids Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 10/15] ice: Unbind the workqueue Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 11/15] ixgbe: Break include dependency cycle Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 12/15] igc: remove autoneg parameter from igc_mac_info Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 13/15] igb: Fix 2 typos in comments in igb_main.c Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 14/15] igbvf: remove unused spinlock Tony Nguyen
2024-11-05 22:23 ` [PATCH net-next 15/15] e1000: Hold RTNL when e1000_down can be called Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107201427.28e00918@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alice.michael@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@intel.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.