From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Bob Beckett <bob.beckett@collabora.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
kernel@collabora.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: 512 byte dma pool segment quirk
Date: Fri, 8 Nov 2024 08:08:06 +0100 [thread overview]
Message-ID: <20241108070806.GA9216@lst.de> (raw)
In-Reply-To: <Zyz2oiQ2pco15HHT@kbusch-mbp>
On Thu, Nov 07, 2024 at 10:19:30AM -0700, Keith Busch wrote:
> We have a constant expression currently, and this is changing it a full
> division in the IO path. :(
Yeah. Given that the device is broken I'd just have it pay the price
and never use the small prp pool instead, which just adds a single
extra branch to the fast path.
next prev parent reply other threads:[~2024-11-08 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 17:46 [PATCH] nvme-pci: qdepth 1 quirk Keith Busch
2024-09-12 6:57 ` Christoph Hellwig
2024-09-12 16:30 ` Robert Beckett
2024-10-29 2:42 ` [PATCH] nvme-pci: Remove O2 Queue Depth quirk Gwendal Grignou
2024-10-29 2:52 ` Greg KH
2024-10-29 7:41 ` Christoph Hellwig
2024-10-29 18:58 ` Gwendal Grignou
2024-10-29 19:16 ` Keith Busch
2024-11-07 16:50 ` [PATCH] nvme-pci: 512 byte dma pool segment quirk Bob Beckett
2024-11-07 17:19 ` Keith Busch
2024-11-07 17:35 ` Robert Beckett
2024-11-08 7:08 ` Christoph Hellwig [this message]
2024-10-29 19:18 ` [PATCH] nvme-pci: Remove O2 Queue Depth quirk Robert Beckett
2024-12-05 21:53 ` Gwendal Grignou
2024-12-05 22:03 ` Keith Busch
2024-12-06 17:11 ` [PATCH] nvme-pci: qdepth 1 quirk Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108070806.GA9216@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bob.beckett@collabora.com \
--cc=kbusch@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.