From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/virtio/virtio_pci_common.c:396 vp_find_vqs_intx() warn: 'vp_dev->pci_dev->irq' from request_irq() not released on lines: 396.
Date: Fri, 8 Nov 2024 20:16:48 +0800 [thread overview]
Message-ID: <202411082004.K40Nskff-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Adrian Hunter <adrian.hunter@intel.com>
CC: Thomas Gleixner <tglx@linutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 906bd684e4b1e517dd424a354744c5b0aebef8af
commit: 5284984a4fbacb0883bfebe905902cdda2891a07 bug: Fix no-return-statement warning with !CONFIG_BUG
date: 7 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 7 months ago
config: sparc-randconfig-r072-20241107 (https://download.01.org/0day-ci/archive/20241108/202411082004.K40Nskff-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411082004.K40Nskff-lkp@intel.com/
smatch warnings:
drivers/virtio/virtio_pci_common.c:396 vp_find_vqs_intx() warn: 'vp_dev->pci_dev->irq' from request_irq() not released on lines: 396.
drivers/scsi/advansys.c:2671 advansys_info() warn: argument 5 to %lX specifier is cast from pointer
drivers/net/ethernet/dec/tulip/winbond-840.c:653 netdev_open() warn: 'np->pci_dev->irq' from request_irq() not released on lines: 653.
drivers/scsi/qla2xxx/qla_nx.c:1685 qla82xx_iospace_config() warn: 'ha->pdev' from pci_request_regions() not released on lines: 1685.
drivers/scsi/myrb.c:3150 DAC960_PD_hw_init() warn: 'cb->io_addr' from __request_region() not released on lines: 3130,3137,3143.
drivers/scsi/myrb.c:3316 DAC960_P_hw_init() warn: 'cb->io_addr' from __request_region() not released on lines: 3296,3303,3309.
vim +396 drivers/virtio/virtio_pci_common.c
e969fed542cae08 drivers/virtio/virtio_pci.c Michael S. Tsirkin 2009-07-26 360
3153234097f6a0d drivers/virtio/virtio_pci_common.c Solomon Tan 2022-04-18 361 static int vp_find_vqs_intx(struct virtio_device *vdev, unsigned int nvqs,
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 362 struct virtqueue *vqs[], vq_callback_t *callbacks[],
13aa8c6c37bd54e drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2022-08-16 363 const char * const names[], const bool *ctx)
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 364 {
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 365 struct virtio_pci_device *vp_dev = to_vp_device(vdev);
ddbeac07a39a81d drivers/virtio/virtio_pci_common.c Wei Wang 2018-12-28 366 int i, err, queue_idx = 0;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 367
0a9b3f47da5b8a2 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 368 vp_dev->vqs = kcalloc(nvqs, sizeof(*vp_dev->vqs), GFP_KERNEL);
0a9b3f47da5b8a2 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 369 if (!vp_dev->vqs)
0a9b3f47da5b8a2 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 370 return -ENOMEM;
0a9b3f47da5b8a2 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 371
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 372 err = request_irq(vp_dev->pci_dev->irq, vp_interrupt, IRQF_SHARED,
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 373 dev_name(&vdev->dev), vp_dev);
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 374 if (err)
0b0f9dc52ed0333 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 375 goto out_del_vqs;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 376
0b0f9dc52ed0333 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 377 vp_dev->intx_enabled = 1;
0a9b3f47da5b8a2 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 378 vp_dev->per_vq_vectors = false;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 379 for (i = 0; i < nvqs; ++i) {
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 380 if (!names[i]) {
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 381 vqs[i] = NULL;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 382 continue;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 383 }
ddbeac07a39a81d drivers/virtio/virtio_pci_common.c Wei Wang 2018-12-28 384 vqs[i] = vp_setup_vq(vdev, queue_idx++, callbacks[i], names[i],
f94682dde5ed23e drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-03-06 385 ctx ? ctx[i] : false,
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 386 VIRTIO_MSI_NO_VECTOR);
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 387 if (IS_ERR(vqs[i])) {
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 388 err = PTR_ERR(vqs[i]);
0b0f9dc52ed0333 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 389 goto out_del_vqs;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 390 }
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 391 }
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 392
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 393 return 0;
0b0f9dc52ed0333 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 394 out_del_vqs:
0b0f9dc52ed0333 drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 395 vp_del_vqs(vdev);
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 @396 return err;
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 397 }
a3cbec69727c8c1 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 398
:::::: The code at line 396 was first introduced by commit
:::::: a3cbec69727c8c149ee2b3652e184818cc269fe6 virtio_pci: split vp_try_to_find_vqs into INTx and MSI-X variants
:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Michael S. Tsirkin <mst@redhat.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-11-08 12:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411082004.K40Nskff-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.