From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [chrome-os:chromeos-6.6 23/149] drivers/media/i2c/gc5035.c:1173:2-3: Unneeded semicolon
Date: Sat, 9 Nov 2024 06:01:58 +0800 [thread overview]
Message-ID: <202411090552.TIs2P4Mu-lkp@intel.com> (raw)
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head: 89f5fb0eb30b534192c362f38bf8e075040e5008
commit: da320c5527fa9b5b7cef05b3c43c895117b4c102 [23/149] BACKPORT: FROMLIST: media: i2c: Add a driver for the Galaxycore GC5035 sensor
config: x86_64-randconfig-r053-20241109 (https://download.01.org/0day-ci/archive/20241109/202411090552.TIs2P4Mu-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411090552.TIs2P4Mu-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/media/i2c/gc5035.c:1173:2-3: Unneeded semicolon
vim +1173 drivers/media/i2c/gc5035.c
1129
1130 static int gc5035_set_ctrl(struct v4l2_ctrl *ctrl)
1131 {
1132 struct gc5035 *gc5035 = container_of(ctrl->handler,
1133 struct gc5035, ctrl_handler);
1134 struct i2c_client *client = gc5035->client;
1135 s64 max;
1136 int ret;
1137
1138 /* Propagate change of current control to all related controls */
1139 switch (ctrl->id) {
1140 case V4L2_CID_VBLANK:
1141 /* Update max exposure while meeting expected vblanking */
1142 max = gc5035->cur_mode->height + ctrl->val
1143 - GC5035_EXPOSURE_MARGIN;
1144 __v4l2_ctrl_modify_range(gc5035->exposure,
1145 gc5035->exposure->minimum, max,
1146 gc5035->exposure->step,
1147 gc5035->exposure->default_value);
1148 break;
1149 }
1150
1151 if (!pm_runtime_get_if_in_use(&client->dev))
1152 return 0;
1153
1154 switch (ctrl->id) {
1155 case V4L2_CID_EXPOSURE:
1156 ret = gc5035_set_exposure(gc5035, ctrl->val);
1157 break;
1158 case V4L2_CID_ANALOGUE_GAIN:
1159 ret = gc5035_set_analogue_gain(gc5035, ctrl->val);
1160 break;
1161 case V4L2_CID_DIGITAL_GAIN:
1162 ret = gc5035_set_digital_gain(gc5035, ctrl->val);
1163 break;
1164 case V4L2_CID_VBLANK:
1165 ret = gc5035_set_vblank(gc5035, ctrl->val);
1166 break;
1167 case V4L2_CID_TEST_PATTERN:
1168 ret = gc5035_enable_test_pattern(gc5035, ctrl->val);
1169 break;
1170 default:
1171 ret = -EINVAL;
1172 break;
> 1173 };
1174
1175 pm_runtime_put(&client->dev);
1176
1177 return ret;
1178 }
1179
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-11-08 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411090552.TIs2P4Mu-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.