From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: michael.chan@broadcom.com, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch, pabeni@redhat.com,
martin.lau@linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next] bnxt_en: ethtool: Supply ntuple rss context action
Date: Sat, 9 Nov 2024 09:25:52 -0800 [thread overview]
Message-ID: <20241109092552.3295381d@kernel.org> (raw)
In-Reply-To: <384c034c23d63dec14e0cc333b8b0b2a778edcf1.1731092818.git.dxu@dxuuu.xyz>
On Fri, 8 Nov 2024 12:07:29 -0700 Daniel Xu wrote:
> Commit 2f4f9fe5bf5f ("bnxt_en: Support adding ntuple rules on RSS
> contexts") added support for redirecting to an RSS context as an ntuple
> rule action. However, it forgot to update the ETHTOOL_GRXCLSRULE
> codepath. This caused `ethtool -n` to always report the action as
> "Action: Direct to queue 0" which is wrong.
>
> Fix by teaching bnxt driver to report the RSS context when applicable.
Ah, so it was a driver bug after all.
Please add a fixes tag here, add a test case for this in
tools/testing/selftests/drivers/net/hw/rss_ctx.py
as a second patch of the series.
--
pw-bot: cr
prev parent reply other threads:[~2024-11-09 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 19:07 [PATCH net-next] bnxt_en: ethtool: Supply ntuple rss context action Daniel Xu
2024-11-09 0:49 ` Michael Chan
2024-11-09 3:10 ` Pavan Chebbi
2024-11-09 4:21 ` Michael Chan
2024-11-09 17:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109092552.3295381d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.