From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB9E1422C7 for ; Sat, 9 Nov 2024 10:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731147360; cv=none; b=VBh2D8PccBEXmHGIUBoVkIM/JLgTyLQeJLM4IUK1To6Lxq6sriIIT5N/VkCmkk1sbNKzT+KERqZnjK6KM/EKFiey/JApk1nWRvFMv6uPYcCYyg3YnXbGoSTr7CjN1zih6H0hMEcOSFPPkt6+rJNW81+43lxM+GiWIH/NZ2Ubl1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731147360; c=relaxed/simple; bh=PeUNqRyBTX2RfCUqnIYiI8K9L0TB9tQOcJ4WeR5E0Eo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jsrzp3UyTau1PFPbQR30c0HCD2l0+lqUkAM09+sVmKBK0PvLsf6P1Z1tV3r8H2kNHtQdhyxPIb3NyO7sO+9xLALxMz5TKLkubR4RlljoyUwwhetLla3X7RTnf3ZQnfhBsqU6nBGepTUaTBs18YsvIkgbispQc+G4fA6CAfxYNh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QD7ntxJH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QD7ntxJH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32CD2C4CECE; Sat, 9 Nov 2024 10:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731147359; bh=PeUNqRyBTX2RfCUqnIYiI8K9L0TB9tQOcJ4WeR5E0Eo=; h=From:To:Cc:Subject:Date:Reply-to:From; b=QD7ntxJHOAHJEM2Z6cEcKBvCeC3B8nOufXjNz9y6cqAJCOK1KlsarsCv517UIYW+d EAnSti0b3UNCwc+OhF1pSgqmTHLv4MMd7WOiwSrsJcZfEw0mFJoXAu6gVUogZltRzs YfG1f+HNuEbPMSvi2Go60lpNw/sGeSVPxwdLn4HY= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-50224: spi: spi-fsl-dspi: Fix crash when not using GPIO chip select Date: Sat, 9 Nov 2024 11:15:32 +0100 Message-ID: <2024110927-CVE-2024-50224-e202@gregkh> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4169; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=PeUNqRyBTX2RfCUqnIYiI8K9L0TB9tQOcJ4WeR5E0Eo=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn6ZvYmh/q/RGzia87dtfuThk5k5IK7+pITV2yKWv4lP kYj+uicjlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZhI2S+G+fHpibrbA6bGH1TN lt16rPj54rr53xjmyk4TuvOG66Gk7HnZIA/J/2+nhk+IAAA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: spi: spi-fsl-dspi: Fix crash when not using GPIO chip select Add check for the return value of spi_get_csgpiod() to avoid passing a NULL pointer to gpiod_direction_output(), preventing a crash when GPIO chip select is not used. Fix below crash: [ 4.251960] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 4.260762] Mem abort info: [ 4.263556] ESR = 0x0000000096000004 [ 4.267308] EC = 0x25: DABT (current EL), IL = 32 bits [ 4.272624] SET = 0, FnV = 0 [ 4.275681] EA = 0, S1PTW = 0 [ 4.278822] FSC = 0x04: level 0 translation fault [ 4.283704] Data abort info: [ 4.286583] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 [ 4.292074] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 4.297130] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 4.302445] [0000000000000000] user address but active_mm is swapper [ 4.308805] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP [ 4.315072] Modules linked in: [ 4.318124] CPU: 2 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc4-next-20241023-00008-ga20ec42c5fc1 #359 [ 4.328130] Hardware name: LS1046A QDS Board (DT) [ 4.332832] pstate: 40000005 (nZcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 4.339794] pc : gpiod_direction_output+0x34/0x5c [ 4.344505] lr : gpiod_direction_output+0x18/0x5c [ 4.349208] sp : ffff80008003b8f0 [ 4.352517] x29: ffff80008003b8f0 x28: 0000000000000000 x27: ffffc96bcc7e9068 [ 4.359659] x26: ffffc96bcc6e00b0 x25: ffffc96bcc598398 x24: ffff447400132810 [ 4.366800] x23: 0000000000000000 x22: 0000000011e1a300 x21: 0000000000020002 [ 4.373940] x20: 0000000000000000 x19: 0000000000000000 x18: ffffffffffffffff [ 4.381081] x17: ffff44740016e600 x16: 0000000500000003 x15: 0000000000000007 [ 4.388221] x14: 0000000000989680 x13: 0000000000020000 x12: 000000000000001e [ 4.395362] x11: 0044b82fa09b5a53 x10: 0000000000000019 x9 : 0000000000000008 [ 4.402502] x8 : 0000000000000002 x7 : 0000000000000007 x6 : 0000000000000000 [ 4.409641] x5 : 0000000000000200 x4 : 0000000002000000 x3 : 0000000000000000 [ 4.416781] x2 : 0000000000022202 x1 : 0000000000000000 x0 : 0000000000000000 [ 4.423921] Call trace: [ 4.426362] gpiod_direction_output+0x34/0x5c (P) [ 4.431067] gpiod_direction_output+0x18/0x5c (L) [ 4.435771] dspi_setup+0x220/0x334 The Linux kernel CVE team has assigned CVE-2024-50224 to this issue. Affected and fixed versions =========================== Issue introduced in 6.4 with commit 9e264f3f85a5 and fixed in 6.6.60 with commit e79c1f1c9100 Issue introduced in 6.4 with commit 9e264f3f85a5 and fixed in 6.11.7 with commit 89f74c968319 Issue introduced in 6.4 with commit 9e264f3f85a5 and fixed in 6.12-rc6 with commit 25f00a13dccf Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-50224 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/spi/spi-fsl-dspi.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/e79c1f1c9100b4adc91c6512985db2cc961aafaa https://git.kernel.org/stable/c/89f74c968319d040739d6238e1c3a4caa16a5a00 https://git.kernel.org/stable/c/25f00a13dccf8e45441265768de46c8bf58e08f6