From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB749233D8E for ; Sat, 9 Nov 2024 10:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731147431; cv=none; b=MEBwjnncMzkJD3KqlJPd4OE/i5xPG+35Rm1qABsImINPIOtjsM6htQ8i9ZsAviBltBenWBrXJ1wmEYppuW7QPjT0wxr0MJ5CaBeM7OSvVvGdobRZXKU19gpHUfkG3YXiz/JeuEXGNfz+KDcLpWQyH193TaLjml1K48JgbUICE9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731147431; c=relaxed/simple; bh=0OghP/N23pz8XPEoFsOQoHR4KuFPjKXudhw9dVAGjd4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RCOSNEn7Ld6mgMQATFjod3QC8XFyKotxLMVsJR9FjgeCgFE+hOJ0GRDGmQj/dJuusXmd2ChZoOGx4tpnfcJIheWsM8zOvLAdZbnxS1Tt4CfvUiatAKcG/tow6E6q5+Zu5zFcEOvmNH/Vpb6k7VR855AyhN6DrO7V9ink3pmVjvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KuVHnKTd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KuVHnKTd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AEBFC4CECE; Sat, 9 Nov 2024 10:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731147430; bh=0OghP/N23pz8XPEoFsOQoHR4KuFPjKXudhw9dVAGjd4=; h=From:To:Cc:Subject:Date:Reply-to:From; b=KuVHnKTd5JVA242ktSYM7bh9DpRE4wshBgHv/jwm7emI1QyZNZTjJZ75YusLMjahg Eju7X44gVX8FFLi/dEC2zSnzxUAq8eF0uGBYkrZrLyBm7D79pJSB4USMZFyTQkdnWE 3CoKiaYw8KmqPDe4EJsrZvFTFaqbK6MJtpKNLPek= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr() Date: Sat, 9 Nov 2024 11:15:36 +0100 Message-ID: <2024110928-CVE-2024-50228-7a2a@gregkh> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=5463; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=0OghP/N23pz8XPEoFsOQoHR4KuFPjKXudhw9dVAGjd4=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn6Zo72T2ee4tdaOeeemu+cugmXevT9LY7KH1hy/OGr8 MAD/CsUO2JZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAifjMYFnTISytcjGBz6RTU uGqr915y6ulnFxjmCggF8/pN8Hz51CWkqStcPfroM4M/AA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: mm: shmem: fix data-race in shmem_getattr() I got the following KCSAN report during syzbot testing: ================================================================== BUG: KCSAN: data-race in generic_fillattr / inode_set_ctime_current write to 0xffff888102eb3260 of 4 bytes by task 6565 on cpu 1: inode_set_ctime_to_ts include/linux/fs.h:1638 [inline] inode_set_ctime_current+0x169/0x1d0 fs/inode.c:2626 shmem_mknod+0x117/0x180 mm/shmem.c:3443 shmem_create+0x34/0x40 mm/shmem.c:3497 lookup_open fs/namei.c:3578 [inline] open_last_lookups fs/namei.c:3647 [inline] path_openat+0xdbc/0x1f00 fs/namei.c:3883 do_filp_open+0xf7/0x200 fs/namei.c:3913 do_sys_openat2+0xab/0x120 fs/open.c:1416 do_sys_open fs/open.c:1431 [inline] __do_sys_openat fs/open.c:1447 [inline] __se_sys_openat fs/open.c:1442 [inline] __x64_sys_openat+0xf3/0x120 fs/open.c:1442 x64_sys_call+0x1025/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:258 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e read to 0xffff888102eb3260 of 4 bytes by task 3498 on cpu 0: inode_get_ctime_nsec include/linux/fs.h:1623 [inline] inode_get_ctime include/linux/fs.h:1629 [inline] generic_fillattr+0x1dd/0x2f0 fs/stat.c:62 shmem_getattr+0x17b/0x200 mm/shmem.c:1157 vfs_getattr_nosec fs/stat.c:166 [inline] vfs_getattr+0x19b/0x1e0 fs/stat.c:207 vfs_statx_path fs/stat.c:251 [inline] vfs_statx+0x134/0x2f0 fs/stat.c:315 vfs_fstatat+0xec/0x110 fs/stat.c:341 __do_sys_newfstatat fs/stat.c:505 [inline] __se_sys_newfstatat+0x58/0x260 fs/stat.c:499 __x64_sys_newfstatat+0x55/0x70 fs/stat.c:499 x64_sys_call+0x141f/0x2d60 arch/x86/include/generated/asm/syscalls_64.h:263 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x54/0x120 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e value changed: 0x2755ae53 -> 0x27ee44d3 Reported by Kernel Concurrency Sanitizer on: CPU: 0 UID: 0 PID: 3498 Comm: udevd Not tainted 6.11.0-rc6-syzkaller-00326-gd1f2d51b711a-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 ================================================================== When calling generic_fillattr(), if you don't hold read lock, data-race will occur in inode member variables, which can cause unexpected behavior. Since there is no special protection when shmem_getattr() calls generic_fillattr(), data-race occurs by functions such as shmem_unlink() or shmem_mknod(). This can cause unexpected results, so commenting it out is not enough. Therefore, when calling generic_fillattr() from shmem_getattr(), it is appropriate to protect the inode using inode_lock_shared() and inode_unlock_shared() to prevent data-race. The Linux kernel CVE team has assigned CVE-2024-50228 to this issue. Affected and fixed versions =========================== Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 4.19.323 with commit 9fb9703cd43e Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 5.4.285 with commit 7cc30ada8432 Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 5.10.229 with commit bda1a99a0dd6 Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 5.15.171 with commit 3d9528484480 Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 6.1.116 with commit 82cae1e30bd9 Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 6.6.60 with commit edd1f9050506 Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 6.11.7 with commit ffd56612566b Issue introduced in 4.3 with commit 44a30220bc0a and fixed in 6.12-rc6 with commit d949d1d14fa2 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-50228 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: mm/shmem.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/9fb9703cd43ee20a6de8ccdef991677b7274cec0 https://git.kernel.org/stable/c/7cc30ada84323be19395094d567579536e0d187e https://git.kernel.org/stable/c/bda1a99a0dd644f31a87d636ac624eeb975cb65a https://git.kernel.org/stable/c/3d9528484480e8f4979b3a347930ed383be99f89 https://git.kernel.org/stable/c/82cae1e30bd940253593c2d4f16d88343d1358f4 https://git.kernel.org/stable/c/edd1f905050686fdc4cfe233d818469fdf7d5ff8 https://git.kernel.org/stable/c/ffd56612566bc23877c8f45def2801f3324a222a https://git.kernel.org/stable/c/d949d1d14fa281ace388b1de978e8f2cd52875cf