All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Boyuan Zhang <boyuan.zhang@amd.com>
Cc: oe-kbuild-all@lists.linux.dev,
	"Linux Infrastructure" <z1.linuxinfra@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>
Subject: [agd5f:amd-staging-drm-next 1244/1265] drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2182: warning: Function parameter or struct member 'inst' not described in 'amdgpu_device_ip_set_powergating_state'
Date: Sun, 10 Nov 2024 11:01:47 +0800	[thread overview]
Message-ID: <202411101047.SmfLBvDk-lkp@intel.com> (raw)

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   51898784baa73c81c9401a271cf94e9ae1d026e1
commit: 585279e00796a46da19b64d5a131c3b5facab8bc [1244/1265] drm/amdgpu: set powergating state by vcn instance
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20241110/202411101047.SmfLBvDk-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241110/202411101047.SmfLBvDk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411101047.SmfLBvDk-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2182: warning: Function parameter or struct member 'inst' not described in 'amdgpu_device_ip_set_powergating_state'


vim +2182 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

d38ceaf99ed015 Alex Deucher  2015-04-20  2166  
e3ecdffac9ccdb Alex Deucher  2018-03-15  2167  /**
e3ecdffac9ccdb Alex Deucher  2018-03-15  2168   * amdgpu_device_ip_set_powergating_state - set the PG state
e3ecdffac9ccdb Alex Deucher  2018-03-15  2169   *
87e3f1366eaa82 Darren Powell 2018-06-25  2170   * @dev: amdgpu_device pointer
e3ecdffac9ccdb Alex Deucher  2018-03-15  2171   * @block_type: Type of hardware IP (SMU, GFX, UVD, etc.)
e3ecdffac9ccdb Alex Deucher  2018-03-15  2172   * @state: powergating state (gate or ungate)
e3ecdffac9ccdb Alex Deucher  2018-03-15  2173   *
e3ecdffac9ccdb Alex Deucher  2018-03-15  2174   * Sets the requested powergating state for all instances of
e3ecdffac9ccdb Alex Deucher  2018-03-15  2175   * the hardware IP specified.
e3ecdffac9ccdb Alex Deucher  2018-03-15  2176   * Returns the error code from the last instance.
e3ecdffac9ccdb Alex Deucher  2018-03-15  2177   */
43fa561fd07fe7 Rex Zhu       2018-03-28  2178  int amdgpu_device_ip_set_powergating_state(void *dev,
5fc3aeeb9e553a yanyang1      2015-05-22  2179  					   enum amd_ip_block_type block_type,
585279e00796a4 Boyuan Zhang  2024-09-29  2180  					   enum amd_powergating_state state,
585279e00796a4 Boyuan Zhang  2024-09-29  2181  					   int inst)
d38ceaf99ed015 Alex Deucher  2015-04-20 @2182  {
43fa561fd07fe7 Rex Zhu       2018-03-28  2183  	struct amdgpu_device *adev = dev;
d38ceaf99ed015 Alex Deucher  2015-04-20  2184  	int i, r = 0;
d38ceaf99ed015 Alex Deucher  2015-04-20  2185  
d38ceaf99ed015 Alex Deucher  2015-04-20  2186  	for (i = 0; i < adev->num_ip_blocks; i++) {
a1255107212675 Alex Deucher  2016-10-13  2187  		if (!adev->ip_blocks[i].status.valid)
9ecbe7f506d36f Alex Deucher  2016-06-23  2188  			continue;
c722865a19f97a Rex Zhu       2017-02-22  2189  		if (adev->ip_blocks[i].version->type != block_type)
c722865a19f97a Rex Zhu       2017-02-22  2190  			continue;
585279e00796a4 Boyuan Zhang  2024-09-29  2191  		if (block_type == AMD_IP_BLOCK_TYPE_VCN &&
585279e00796a4 Boyuan Zhang  2024-09-29  2192  				adev->ip_blocks[i].instance != inst)
585279e00796a4 Boyuan Zhang  2024-09-29  2193  			continue;
c722865a19f97a Rex Zhu       2017-02-22  2194  		if (!adev->ip_blocks[i].version->funcs->set_powergating_state)
c722865a19f97a Rex Zhu       2017-02-22  2195  			continue;
c722865a19f97a Rex Zhu       2017-02-22  2196  		r = adev->ip_blocks[i].version->funcs->set_powergating_state(
c9188ea9675f46 Boyuan Zhang  2024-09-29  2197  			&adev->ip_blocks[i], state);
d38ceaf99ed015 Alex Deucher  2015-04-20  2198  		if (r)
c722865a19f97a Rex Zhu       2017-02-22  2199  			DRM_ERROR("set_powergating_state of IP block <%s> failed %d\n",
c722865a19f97a Rex Zhu       2017-02-22  2200  				  adev->ip_blocks[i].version->funcs->name, r);
d38ceaf99ed015 Alex Deucher  2015-04-20  2201  	}
d38ceaf99ed015 Alex Deucher  2015-04-20  2202  	return r;
d38ceaf99ed015 Alex Deucher  2015-04-20  2203  }
d38ceaf99ed015 Alex Deucher  2015-04-20  2204  

:::::: The code at line 2182 was first introduced by commit
:::::: d38ceaf99ed015f2a0b9af3499791bd3a3daae21 drm/amdgpu: add core driver (v4)

:::::: TO: Alex Deucher <alexander.deucher@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-11-10  3:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202411101047.SmfLBvDk-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=boyuan.zhang@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=z1.linuxinfra@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.