From: Simon Horman <horms@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] macsec: add some of the lower device's features when offloading
Date: Mon, 11 Nov 2024 12:15:45 +0000 [thread overview]
Message-ID: <20241111121545.GW4507@kernel.org> (raw)
In-Reply-To: <8b32c3011d269d6f149724e80c1ffe67c9534067.1730929545.git.sd@queasysnail.net>
On Thu, Nov 07, 2024 at 12:13:29AM +0100, Sabrina Dubroca wrote:
> This commit extends the set of netdevice features supported by macsec
> devices when offload is enabled, which increases performance
> significantly (for a single TCP stream: 17.5Gbps to 38.5Gbps on my
> test machines).
>
> Commit c850240b6c41 ("net: macsec: report real_dev features when HW
> offloading is enabled") previously attempted something similar, but
> had to be reverted (commit 8bcd560ae878 ("Revert "net: macsec: report
> real_dev features when HW offloading is enabled"")) because the set of
> features it exposed was too large.
>
> During initialization, all features are set, and they're then removed
> via ndo_fix_features (macsec_fix_features). This allows the
> offloadable features to be automatically enabled if offloading is
> turned on after device creation.
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-11-11 12:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 23:13 [PATCH net-next 0/8] macsec: inherit lower device's features and TSO limits when offloading Sabrina Dubroca
2024-11-06 23:13 ` [PATCH net-next 1/8] netdevsim: add more hw_features Sabrina Dubroca
2024-11-11 12:15 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 2/8] selftests: netdevsim: add a test checking ethtool features Sabrina Dubroca
2024-11-11 12:15 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 3/8] macsec: add some of the lower device's features when offloading Sabrina Dubroca
2024-11-11 12:15 ` Simon Horman [this message]
2024-11-06 23:13 ` [PATCH net-next 4/8] macsec: clean up local variables in macsec_notify Sabrina Dubroca
2024-11-11 12:15 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 5/8] macsec: inherit lower device's TSO limits when offloading Sabrina Dubroca
2024-11-11 12:16 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 6/8] selftests: move macsec offload tests from net/rtnetlink to drivers/net/netdvesim Sabrina Dubroca
2024-11-11 12:16 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 7/8] selftests: netdevsim: add test toggling macsec offload Sabrina Dubroca
2024-11-11 12:16 ` Simon Horman
2024-11-06 23:13 ` [PATCH net-next 8/8] selftests: netdevsim: add ethtool features to macsec offload tests Sabrina Dubroca
2024-11-11 12:16 ` Simon Horman
2024-11-11 22:20 ` [PATCH net-next 0/8] macsec: inherit lower device's features and TSO limits when offloading patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111121545.GW4507@kernel.org \
--to=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.