From: codekipper@gmail.com
To: linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
linux-sound@vger.kernel.org, lander@jagmn.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, jernej.skrabec@gmail.com, samuel@sholland.org,
andre.przywara@arm.com, wens@csie.org,
u.kleine-koenig@baylibre.com,
Marcus Cooper <codekipper@gmail.com>
Subject: [PATCH 2/3] ASoC: sun4i-spdif: Always set the valid data to be the MSB
Date: Mon, 11 Nov 2024 17:55:30 +0100 [thread overview]
Message-ID: <20241111165600.57219-3-codekipper@gmail.com> (raw)
In-Reply-To: <20241111165600.57219-1-codekipper@gmail.com>
From: Marcus Cooper <codekipper@gmail.com>
This doesn't affect 16bit formats and allows us to properly run
24bit formats.
Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
sound/soc/sunxi/sun4i-spdif.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 7cf623cbe9ed4..5a9407aaa1a19 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -202,6 +202,10 @@ static void sun4i_spdif_configure(struct sun4i_spdif_dev *host)
regmap_update_bits(host->regmap, SUN4I_SPDIF_FCTL,
quirks->val_fctl_ftx, quirks->val_fctl_ftx);
+ /* Valid data at the MSB of TXFIFO Register */
+ regmap_update_bits(host->regmap, SUN4I_SPDIF_FCTL,
+ SUN4I_SPDIF_FCTL_TXIM, 0);
+
/* clear TX counter */
regmap_write(host->regmap, SUN4I_SPDIF_TXCNT, 0);
}
@@ -323,9 +327,6 @@ static int sun4i_spdif_hw_params(struct snd_pcm_substream *substream,
return ret;
}
- regmap_update_bits(host->regmap, SUN4I_SPDIF_FCTL,
- SUN4I_SPDIF_FCTL_TXIM, SUN4I_SPDIF_FCTL_TXIM);
-
switch (rate) {
case 22050:
case 24000:
--
2.47.0
next prev parent reply other threads:[~2024-11-11 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 16:55 [PATCH 0/3] ASoC: sun4i-spdif: Add 24bit support codekipper
2024-11-11 16:55 ` [PATCH 1/3] ASoC: sun4i-spdif: Add clock multiplier settings codekipper
2024-11-11 16:55 ` codekipper [this message]
2024-11-11 16:55 ` [PATCH 3/3] ASoC: sun4i-spdif: Add working 24bit audio support codekipper
2024-12-10 13:36 ` [PATCH 0/3] ASoC: sun4i-spdif: Add 24bit support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111165600.57219-3-codekipper@gmail.com \
--to=codekipper@gmail.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lander@jagmn.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.