From: Jakub Kicinski <kuba@kernel.org>
To: Abhinav Saxena <xandfury@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Allison Henderson <allison.henderson@oracle.com>,
Russell King <linux@armlinux.org.uk>,
Dragos Tatulea <dtatulea@nvidia.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [Intel-wired-lan] [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs
Date: Mon, 11 Nov 2024 19:03:56 -0800 [thread overview]
Message-ID: <20241111190356.0aefe1b9@kernel.org> (raw)
In-Reply-To: <20241108202548.140511-1-xandfury@gmail.com>
On Fri, 8 Nov 2024 13:25:47 -0700 Abhinav Saxena wrote:
> diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
> index f355f0166f1b..df4b4c4a15d5 100644
> --- a/Documentation/networking/switchdev.rst
> +++ b/Documentation/networking/switchdev.rst
> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
> monitoring NETDEV_CHANGEUPPER notifications. For example, a port moved into a
> bond will see its upper master change. If that bond is moved into a bridge,
> the bond's upper master will change. And so on. The driver will track such
> -movements to know what position a port is in in the overall topology by
> +movements to know what position a port is in the overall topology by
Are you sure? The first 'in' is for position, the second for topology.
Equivalent to:
movements to know in what position a port is in the overall topology by
^^ ^^
We can rephrase to avoid the double in:
The driver will track such movements to know the position of a port
within the overall topology by registering for netdevice events and
acting on NETDEV_CHANGEUPPER.
> registering for netdevice events and acting on NETDEV_CHANGEUPPER.
--
pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Abhinav Saxena <xandfury@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Allison Henderson <allison.henderson@oracle.com>,
Russell King <linux@armlinux.org.uk>,
Dragos Tatulea <dtatulea@nvidia.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs
Date: Mon, 11 Nov 2024 19:03:56 -0800 [thread overview]
Message-ID: <20241111190356.0aefe1b9@kernel.org> (raw)
In-Reply-To: <20241108202548.140511-1-xandfury@gmail.com>
On Fri, 8 Nov 2024 13:25:47 -0700 Abhinav Saxena wrote:
> diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
> index f355f0166f1b..df4b4c4a15d5 100644
> --- a/Documentation/networking/switchdev.rst
> +++ b/Documentation/networking/switchdev.rst
> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
> monitoring NETDEV_CHANGEUPPER notifications. For example, a port moved into a
> bond will see its upper master change. If that bond is moved into a bridge,
> the bond's upper master will change. And so on. The driver will track such
> -movements to know what position a port is in in the overall topology by
> +movements to know what position a port is in the overall topology by
Are you sure? The first 'in' is for position, the second for topology.
Equivalent to:
movements to know in what position a port is in the overall topology by
^^ ^^
We can rephrase to avoid the double in:
The driver will track such movements to know the position of a port
within the overall topology by registering for netdevice events and
acting on NETDEV_CHANGEUPPER.
> registering for netdevice events and acting on NETDEV_CHANGEUPPER.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-12 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 20:25 [Intel-wired-lan] [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs Abhinav Saxena
2024-11-08 20:25 ` Abhinav Saxena
2024-11-08 20:25 ` [Intel-wired-lan] [PATCH 2/2] docs: net: Fix sfp-phylink whitespace Abhinav Saxena
2024-11-08 20:25 ` Abhinav Saxena
2024-11-12 3:03 ` Jakub Kicinski [this message]
2024-11-12 3:03 ` [PATCH 1/2] docs: net: Fix text in eth/intel, mlx5 and switchdev docs Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111190356.0aefe1b9@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rds-devel@oss.oracle.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=xandfury@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.