From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Scott Fan <fancp2007@gmail.com>
Cc: buildroot@buildroot.org, Alexey Brodkin <alexey.brodkin@synopsys.com>
Subject: Re: [Buildroot] [PATCH 2/2] configs/cubieboard2: switch to use extlinux.conf
Date: Mon, 11 Nov 2024 22:31:03 +0100 [thread overview]
Message-ID: <20241111223103.07d01414@windsurf> (raw)
In-Reply-To: <20241108155434.1924823-2-fancp2007@gmail.com>
Hello,
On Fri, 8 Nov 2024 23:54:32 +0800
Scott Fan <fancp2007@gmail.com> wrote:
> Switch to extlinux instead of U-Boot boot script.
> Remove obsolete entry from the .checkpackageignore file.
> Drop custom boot script and genimage config.
> Drop unnecessary generic and host configs.
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
Nice change!
> diff --git a/board/cubietech/cubieboard2/rootfs_overlay/boot/extlinux/extlinux.conf b/board/cubietech/cubieboard2/rootfs_overlay/boot/extlinux/extlinux.conf
> new file mode 100644
> index 0000000000..8465f6deaf
> --- /dev/null
> +++ b/board/cubietech/cubieboard2/rootfs_overlay/boot/extlinux/extlinux.conf
> @@ -0,0 +1,5 @@
> +DEFAULT linux
Drop this line.
> +LABEL linux
> + KERNEL /boot/zImage
> + DEVICETREE /boot/sun7i-a20-cubieboard2.dtb
> + APPEND console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p1 rootwait
Could you use lowercase label, kernel, devicetree and append, like we
do in the other extlinux.conf file?
I see
board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
is the only one using upper-case, but that should be fixed, just for
the sake of consistency.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-11-11 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 15:54 [Buildroot] [PATCH 1/2] configs/cubieboard2: bump Linux to 6.11.6 and U-Boot to 2024.10 Scott Fan
2024-11-08 15:54 ` [Buildroot] [PATCH 2/2] configs/cubieboard2: switch to use extlinux.conf Scott Fan
2024-11-11 21:31 ` Thomas Petazzoni via buildroot [this message]
2024-11-12 12:32 ` [Buildroot] [PATCH v2 " Scott Fan
2024-11-11 21:29 ` [Buildroot] [PATCH 1/2] configs/cubieboard2: bump Linux to 6.11.6 and U-Boot to 2024.10 Thomas Petazzoni via buildroot
2024-11-12 12:32 ` [Buildroot] [PATCH v2 1/2] configs/cubieboard2: bump Linux to 6.11.7 " Scott Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111223103.07d01414@windsurf \
--to=buildroot@buildroot.org \
--cc=alexey.brodkin@synopsys.com \
--cc=fancp2007@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.